Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterating on codecov config #418

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Jul 17, 2019

Which problem is this PR solving?

Inadvertently removed all codecov status checks from master in a previous PR.

Short description of the changes

This adds project and patch based on the default config with the change that patch.default.only_pulls is set to true.

@tiffon tiffon requested a review from everett980 July 17, 2019 18:06
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #418 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   91.41%   91.46%   +0.05%     
==========================================
  Files         174      174              
  Lines        3915     3915              
  Branches      897      897              
==========================================
+ Hits         3579     3581       +2     
+ Misses        298      296       -2     
  Partials       38       38
Impacted Files Coverage Δ
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 91.52% <0%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b21af...6b631d3. Read the comment docs.

@tiffon tiffon merged commit 9b816a5 into jaegertracing:master Jul 17, 2019
@tiffon tiffon deleted the rm-patch-check-from-master branch July 17, 2019 21:16
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Iterating on codecov config
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants