Fixes handling of numeric strings in span tag values

[matus-m]

Signed-off-by: Matus Majchrak matus.majchrak@gmail.com
Fixes the rendering of span tag values that contain numeric strings

Hi this is my first PR to this project so bear with me :)

Resolves #396

Which problem is this PR solving?

As stated in bug #396, span tags containing numeric strings will be converted to actual numbers and rendered in scientific notation if they are large enough.

Short description of the changes

As hinted by @tiffon, this commit limits the json conversion of tag values only to cases, when the value is an actual string and is not a primitive type(i.e. only if it is object or array)

The one open point from my side, is what would be a meaningful test for the rendering of tag value containing real json object(if it is required) as I had some trouble creating an elegant test case that would verify the dangerouslySetInnerHTML contents(right now I verify it by call to html() and then string matching...) and what role should tag type attribute play in the rendering:
e.g.
given span tag payload:

{
  "key": "numberTag",
 "type": "int",
  "value": 123
},
{
  "key": "numberAsString",
 "type": "string",
  "value": "123"
}

Not sure if this is a valid case.
In any case, looking forward to your feedback.

[codecov]

Codecov Report

Merging #436 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   90.98%   90.94%   -0.05%     
==========================================
  Files         177      177              
  Lines        4106     4108       +2     
  Branches      991      992       +1     
==========================================
  Hits         3736     3736              
- Misses        327      329       +2     
  Partials       43       43

Impacted Files	Coverage Δ
.../TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx	100% <100%> (ø)	⬆️
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx	89.83% <0%> (-3.39%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfb026...4b61e23. Read the comment docs.

[tiffon]

This looks great. I think the check could be folded into parseIfJson, i.e. parseIfComplexJson, but this works, too.

[matus-m]

alright, could you, please, give it one more try?

[tiffon]

Thanks for making the changes. A couple of small questions...

[tiffon]

I think this can be jsonObjectOrArrayStartRegex.test(value) to avoid generating match data?

[matus-m]

right

[tiffon]

Is this log statement a left-over?

[matus-m]

oops, fixed now

[tiffon]

👍

[tiffon]

🎉 Thanks for contributing!! 🎉

[matus-m]

Pleasure is all mine, well setup project and great feedback.