Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script tags from config to body #455

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • We need the ability to run non-OSS code on the UI without treating Jaeger UI as a component library.

Short description of the changes

  • Adds scripts field to config, which are added to the document body.
  • Initially only inline scripts are supported, as the config is a JSON and we need the ability to define an onLoad function if we were to use a src

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #455 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   88.81%   88.88%   +0.07%     
==========================================
  Files         184      185       +1     
  Lines        4239     4248       +9     
  Branches     1021     1023       +2     
==========================================
+ Hits         3765     3776      +11     
+ Misses        428      426       -2     
  Partials       46       46
Impacted Files Coverage Δ
packages/jaeger-ui/src/components/App/index.js 100% <100%> (ø) ⬆️
...ges/jaeger-ui/src/utils/config/process-scripts.tsx 100% <100%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 91.52% <0%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2259b96...8859ba5. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have some README that describes the syntax of the config file, please add a note to it about the new element.

Otherwise, it should be added to the docs on the website.

@everett980
Copy link
Collaborator Author

@yurishkuro the only documentation for the config json in this repo is a link to jaegertracing.io, otherwise we rely on type definitions.
I'll update the linked page tomorrow.

@everett980 everett980 merged commit 4815f92 into jaegertracing:master Sep 25, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Add script tags from config to body
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants