Consume new API format #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 89.37% 89.35% -0.03%
==========================================
Files 189 189
Lines 4424 4434 +10
Branches 1061 1063 +2
==========================================
+ Hits 3954 3962 +8
- Misses 424 426 +2
Partials 46 46
Continue to review full report at Codecov.
|
Signed-off-by: Everett Ross <reverett@uber.com>
vprithvi
reviewed
Oct 14, 2019
Comment on lines
+193
to
+196
| { | ||
| key: 'exemplar_trace_id', | ||
| value: `trace ${i} a`, | ||
| }, |
There was a problem hiding this comment.
@yurishkuro I don't recall our previous discussion - but is there a particular reason to prefer this to combining multivalued keys in the backend as so?
{
key: 'exemplar_trace_id',
values: {'traceId1', 'traceId2`, ...}
}
There was a problem hiding this comment.
Additionally, is there a reason to prefer the above implementation or the live implementation over:
attributes: {
exemplar_trace_id: ['traceID1', 'traceID2', ...],
[someOtherKey]: ['value0', 'value1'],
},
vprithvi
approved these changes
Oct 15, 2019
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…ad-format Consume new API format Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload format has changed slightly, update
transformDdgDatato handle this change, and update view traces to consume multiple traceIDs per path elem.