Add ga dimension for config cookie #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
- Coverage 92.92% 92.85% -0.08%
==========================================
Files 197 197
Lines 4808 4814 +6
Branches 1160 1162 +2
==========================================
+ Hits 4468 4470 +2
- Misses 299 303 +4
Partials 41 41 Continue to review full report at Codecov.
|
yurishkuro
reviewed
Feb 4, 2020
yurishkuro
reviewed
Feb 4, 2020
| @@ -45,6 +45,13 @@ const gaID = _get(config, 'tracking.gaID'); | |||
| export const isGaEnabled = isTest || isDebugMode || (isProd && Boolean(gaID)); | |||
| const isErrorsEnabled = isDebugMode || (isGaEnabled && Boolean(_get(config, 'tracking.trackErrors'))); | |||
|
|
|||
| const cookieToDimension = _get(config, 'tracking.cookieToDimension'); | |||
| if (cookieToDimension) { | |||
| const match = ` ${document.cookie}`.match(new RegExp(`[; ]${cookieToDimension.cookie}=([^\\s;]*)`)); | |||
There was a problem hiding this comment.
- what is the meaning of the leading space?
- are you forced to use regexp because there is no structured API to access cookies?
There was a problem hiding this comment.
- Leading space because the regex looks for
;and/ordocument.cookiestring. - Correct. There are npm libraries for this (of course) but a library for a simple RegEx is overkill, and libraries may make certain assumptions about the cookies that aren't relevant here, meanwhile it's easy to know what our own RegEx is precisely doing.
Signed-off-by: Everett Ross <reverett@uber.com>
The other code in the file run on JS load is also untested. I'm not sure of a good approach for it, so I'd leave it for now. I'll dogfood it in staging w/ the config change before landing. |
Signed-off-by: Everett Ross <reverett@uber.com>
|
Dogfooded successfully. |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Add ga dimension for config cookie * Update cookiesToDimensions to an array * Move when cookie dimensions are set Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes