Dedupled search results DDG paths #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Apr 8, 2020
| @@ -25,7 +25,9 @@ function transformTracesToPaths( | |||
| focalService: string, | |||
| focalOperation?: string | |||
| ): TDdgPayload { | |||
| const dependencies: TDdgPayloadPath[] = []; | |||
| // const dependenciesMap: TDdgPayloadPath[] = []; | |||
There was a problem hiding this comment.
Ups, removed, thanks.
rubenvp8510
force-pushed
the
Issue-503
branch
2 times, most recently
from
402be04
to
0f7ca18
Compare
yurishkuro
reviewed
Apr 8, 2020
yurishkuro
approved these changes
Apr 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 92.89% 92.90%
=======================================
Files 200 200
Lines 4912 4917 +5
Branches 1212 1213 +1
=======================================
+ Hits 4563 4568 +5
Misses 309 309
Partials 40 40
Continue to review full report at Codecov.
|
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Dedupled search results DDG paths Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Add deduplet ddg paths test Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com
Which problem is this PR solving?
Short description of the changes