Test quality metrics and DetailsCard #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 89.99% 93.41% +3.42%
==========================================
Files 214 216 +2
Lines 5225 5227 +2
Branches 1338 1337 -1
==========================================
+ Hits 4702 4883 +181
+ Misses 480 303 -177
+ Partials 43 41 -2
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
May 19, 2020
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Test existing files + CircularProgressbar * Test QualityMetrics/!index, move & rename Resizer * Add key to metric details, test QualityMetrics * Move ExamplesLink&DetailsCard, split&test DC * Clean up types files * Clean up types files * Clean up tests Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
components/QualityMetricsDetailsCard,ExamplesLink, andTraceTimelineResizertocomponents/common, and test.DetailsCardinto smaller, easier to maintain files.