Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain "self time" in graph view #655

Merged

Conversation

yurishkuro
Copy link
Member

Fixes #653

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         227      227           
  Lines        5906     5906           
  Branches     1484     1484           
=======================================
  Hits         5564     5564           
  Misses        303      303           
  Partials       39       39           
Impacted Files Coverage Δ
...src/components/TracePage/TraceGraph/TraceGraph.tsx 95.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f952882...00a120a. Read the comment docs.

@yurishkuro
Copy link
Member Author

Travis was successful , but didn't update the PR, force merging

https://travis-ci.org/github/jaegertracing/jaeger-ui/builds/735219248

@yurishkuro yurishkuro merged commit 9fa9d74 into jaegertracing:master Oct 13, 2020
@yurishkuro yurishkuro deleted the explain-self-time-issue-653 branch October 13, 2020 01:50
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explanation about "Self Time" in "Trace Graph" view
1 participant