Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Event for Service Name in Search Form #842

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Track Event for Service Name in Search Form #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43581ae
serviceName Track Event
vvvprabhakar Oct 29, 2021
f90400a
Merge branch 'master' into issue-841
vvvprabhakar Oct 29, 2021
b5722fa
Merge branch 'master' into issue-841
vvvprabhakar Nov 25, 2021
04b3d85
Merge branch 'master' into issue-841
yurishkuro Nov 25, 2021
3d8fc8e
Merge branch 'main' into issue-841
vvvprabhakar Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export function submitForm(fields, searchTraces) {
end = times.end;
}

trackFormInput(resultsLimit, operation, tags, minDuration, maxDuration, lookback);
trackFormInput(resultsLimit, operation, tags, minDuration, maxDuration, lookback, service);

searchTraces({
service,
Expand Down
6 changes: 4 additions & 2 deletions packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
CATEGORY_OPERATION,
CATEGORY_SORTBY,
CATEGORY_TAGS,
CATEGORY_SERVICE,
} from './SearchForm.track';
import { FORM_CHANGE_ACTION_TYPE } from '../../constants/search-form';
import { trackEvent } from '../../utils/tracking';
Expand All @@ -39,8 +40,8 @@ describe('GA tracking', () => {

it('sends form input to GA', () => {
trackEvent.mockClear();
trackFormInput(0, '', {}, 0, 0, '');
expect(trackEvent.mock.calls.length).toBe(6);
trackFormInput(0, '', {}, 0, 0, '', '');
expect(trackEvent.mock.calls.length).toBe(7);
const categoriesTracked = trackEvent.mock.calls.map(call => call[0]).sort();
expect(categoriesTracked).toEqual(
[
Expand All @@ -50,6 +51,7 @@ describe('GA tracking', () => {
CATEGORY_MAX_DURATION,
CATEGORY_MIN_DURATION,
CATEGORY_LOOKBACK,
CATEGORY_SERVICE,
].sort()
);
});
Expand Down
6 changes: 4 additions & 2 deletions packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,23 @@ export const CATEGORY_TAGS = `${FORM_CATEGORY_BASE}/tags`;
export const CATEGORY_MIN_DURATION = `${FORM_CATEGORY_BASE}/min_duration`;
export const CATEGORY_MAX_DURATION = `${FORM_CATEGORY_BASE}/max_duration`;
export const CATEGORY_LIMIT = `${FORM_CATEGORY_BASE}/limit`;

export const CATEGORY_SERVICE = `${FORM_CATEGORY_BASE}/serviceName`;
export function trackFormInput(
resultsLimit: number,
operation: string,
tags: any,
minDuration: number,
maxDuration: number,
lookback: string
lookback: string,
serviceName: string
) {
trackEvent(CATEGORY_OPERATION, operation === constants.DEFAULT_OPERATION ? ACTION_DEFAULT : ACTION_SET);
trackEvent(CATEGORY_LIMIT, resultsLimit === constants.DEFAULT_LIMIT ? ACTION_DEFAULT : ACTION_SET);
trackEvent(CATEGORY_MAX_DURATION, maxDuration ? ACTION_SET : ACTION_CLEAR);
trackEvent(CATEGORY_MIN_DURATION, minDuration ? ACTION_SET : ACTION_CLEAR);
trackEvent(CATEGORY_TAGS, tags ? ACTION_SET : ACTION_CLEAR);
trackEvent(CATEGORY_LOOKBACK, lookback);
trackEvent(CATEGORY_SERVICE, serviceName);
}

export const middlewareHooks = {
Expand Down