Log configuration options for memory storage (#852)

* Log configuration options for memory storage Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Provide logger to memory factory tests Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jaegertracing · May 31, 2018 · 4402978 · 4402978
1 parent dc48730
commit 4402978
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugin/storage/memory/factory.go b/plugin/storage/memory/factory.go
@@ -52,6 +52,7 @@ func (f *Factory) InitFromViper(v *viper.Viper) {
 func (f *Factory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error {
 	f.metricsFactory, f.logger = metricsFactory, logger
 	f.store = WithConfiguration(f.options.Configuration)
+	logger.Info("Memory storage configuration", zap.Any("configuration", f.store.config))
 	return nil
 }
 

diff --git a/plugin/storage/memory/factory_test.go b/plugin/storage/memory/factory_test.go
@@ -18,6 +18,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"go.uber.org/zap"
 
 	"github.com/jaegertracing/jaeger/pkg/config"
 	"github.com/jaegertracing/jaeger/storage"
@@ -27,7 +28,7 @@ var _ storage.Factory = new(Factory)
 
 func TestMemoryStorageFactory(t *testing.T) {
 	f := NewFactory()
-	assert.NoError(t, f.Initialize(nil, nil))
+	assert.NoError(t, f.Initialize(nil, zap.NewNop()))
 	assert.NotNil(t, f.store)
 	reader, err := f.CreateSpanReader()
 	assert.NoError(t, err)