Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log configuration options for memory storage #852

Merged
merged 2 commits into from
May 31, 2018
Merged

Log configuration options for memory storage #852

merged 2 commits into from
May 31, 2018

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

  • With Add bounds to memory storage #845, there's now a configuration option to set the maximum number of traces to store in memory, but there's no positive feedback about the actual value of this configuration option during runtime. This PR adds a log statement with the configuration option, like:
$ MEMORY_MAX_TRACES=100 go run cmd/standalone/main.go
{"level":"info","ts":1527668119.7661645,"caller":"memory/factory.go:55","msg":"Memory storage configuration","configuration":{"MaxTraces":100}}

Short description of the changes

  • Added log statement with the contents of the configuration object

@jpkrohling
Log configuration options for memory storage
261e656 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@ghost ghost assigned jpkrohling May 30, 2018
@ghost ghost added the review label May 30, 2018
@jpkrohling
Provide logger to memory factory tests
de12cdd 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@yurishkuro yurishkuro merged commit 4402978 into jaegertracing:master May 31, 2018
@ghost ghost removed the review label May 31, 2018
mabn pushed a commit to mabn/jaeger that referenced this pull request Jun 13, 2018
Merge branch 'master' into influx
88178f6 
* master:
  Add back quotes
  Adding CONTRIBUTING_GUIDELINES.md (jaegertracing#864)
  Close span writer in standalone (jaegertracing#863)
  Fix Process IP problem/inconsistency (jaegertracing#821) (jaegertracing#865)
  Use NewSpanID()/NewTraceID() instead of type-specific intializations (jaegertracing#861)
  Do not create duplicate child-of reference from parentSpanId (jaegertracing#860)
  Switch to codecov (jaegertracing#857)
  Log configuration options for memory storage (jaegertracing#852)
  Add jpkrohling to maintainers / code owners (jaegertracing#851)
@jpkrohling jpkrohling deleted the JPK-Log-max-traces branch July 28, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpkrohling @yurishkuro @pavolloffay