Improving deserializer testing

Signed-off-by: Geoffrey Beausire <g.beausire@criteo.com>
jaegertracing · Dec 17, 2018 · a273a5c · a273a5c
1 parent abf8a9a
commit a273a5c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/model/converter/thrift/zipkin/deserialize_test.go b/model/converter/thrift/zipkin/deserialize_test.go
@@ -27,3 +27,16 @@ func TestDeserializeWithBadListStart(t *testing.T) {
 	_, err := DeserializeThrift(append([]byte{0, 255, 255}, spanBytes...))
 	assert.Error(t, err)
 }
+
+func TestDeserializeWithCorruptedList(t *testing.T) {
+	spanBytes := ZipkinSerialize([]*zipkincore.Span{{}})
+	spanBytes[2] = 255
+	_, err := DeserializeThrift(spanBytes)
+	assert.Error(t, err)
+}
+
+func TestDeserialize(t *testing.T) {
+	spanBytes := ZipkinSerialize([]*zipkincore.Span{{}})
+	_, err := DeserializeThrift(spanBytes)
+	assert.NoError(t, err)
+}
diff --git a/plugin/storage/kafka/marshalling_test.go b/plugin/storage/kafka/marshalling_test.go
@@ -44,18 +44,21 @@ func testMarshallerAndUnmarshaller(t *testing.T, marshaller Marshaller, unmarsha
 }
 
 func TestZipkinThriftUnmarshaller(t *testing.T) {
+	operationName := "foo"
 	bytes := zipkin.ZipkinSerialize([]*zipkincore.Span{
 		{
 			ID: 12345,
-			Name: "foo",
+			Name: operationName,
 			Annotations: []*zipkincore.Annotation{
-				{Host: &zipkincore.Endpoint{ServiceName: "foo"}},
+				{Host: &zipkincore.Endpoint{ServiceName: "foobar"}},
 			},
 		},
 	})
 	unmarshaller := NewZipkinThriftUnmarshaller()
-	_, err := unmarshaller.Unmarshal(bytes)
+	resultSpan, err := unmarshaller.Unmarshal(bytes)
+
 	assert.NoError(t, err)
+	assert.Equal(t, operationName, resultSpan.OperationName)
 }
 
 func TestZipkinThriftUnmarshallerErrorNoService(t *testing.T) {