Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querying data repeatedly makes duplicated span on jaeger-ui #1297

Closed
crazycomputer opened this issue Jan 24, 2019 · 2 comments · Fixed by #1677
Closed

querying data repeatedly makes duplicated span on jaeger-ui #1297

crazycomputer opened this issue Jan 24, 2019 · 2 comments · Fixed by #1677

Comments

@crazycomputer
Copy link

Requirement - what kind of business use case are you trying to solve?

When using the search function of jaeger-query, if the data to be queried is very large, the method multiRead in "github.com/jaegertracing/jaeger/plugin/storage/es/spanstore/reader.go" will query the storage more than once. There is a bug in this method that causes queried data may be repeated probably.
https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/es/spanstore/reader.go

Problem - what in Jaeger blocks you from solving the requirement?

default
The array of searchRequests is been maked Outside the for loop,the length of it equals the slice of traceIds. When it query second time in the for loop,the length of traceIds will be changed,but the length of searchRequests will not. This bug may cause repeated traceId be queried.like this:
20190124-200601 espace
There is #duplicated span in this trace

Proposal - what do you suggest to solve the problem or improve the existing situation?

Maybe we can initial searchRequests in for loop,the length of it will equals the slice of traceIds Always.

Any open questions to address

@black-adder
Copy link
Contributor

good catch!

@pavolloffay
Copy link
Member

done in #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants