Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated spans when querying Elasticsearch #1677

Merged
merged 1 commit into from Jul 23, 2019

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Jul 23, 2019

Resolves #1297
Rebased #1298 and added test

cc) @Volcannozzz

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #1677 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1677   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         193      193           
  Lines        9284     9284           
=======================================
  Hits         9144     9144           
  Misses        111      111           
  Partials       29       29
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428cc1a...d79a638. Read the comment docs.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

querying data repeatedly makes duplicated span on jaeger-ui
2 participants