Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up references to "tcollector" #285

Closed
yurishkuro opened this issue Jul 26, 2017 · 1 comment · Fixed by #2704
Closed

Clean-up references to "tcollector" #285

yurishkuro opened this issue Jul 26, 2017 · 1 comment · Fixed by #2704

Comments

@yurishkuro
Copy link
Member

"tcollector" is the old name we used internally, for historical reasons. Many error messages in the agent still refer to it, we should clean that up.

@jpkrohling
Copy link
Contributor

This is what I could find:

$ grep tcollector . -r
./cmd/agent/app/httpserver/server_test.go:			description: "baggage tcollector error",
./cmd/agent/README.md:`tcollector` service.
./cmd/agent/README.md:remote `tcollector` service. Then the server converts
./CHANGELOG.md:- Rename tcollector proxy metric in agent ([#1182](https://github.com/jaegertracing/jaeger/pull/1182), [@pavolloffay](https://github.com/pavolloffay))
./CHANGELOG.md:jaeger_http_server_errors{source="tcollector-proxy",status="5xx"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants