Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up "tcollector" references #2704

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

sniperking1234
Copy link
Contributor

@sniperking1234 sniperking1234 commented Dec 25, 2020

Signed-off-by: Chen Zhengwei chenzhengwei@inspur.com

Which problem is this PR solving?

Short description of the changes

  • Clean-up the outdated "tcollector".

Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com>

Signed-off-by: chen zhengwei <chenzhengwei@inspur.com>
@yurishkuro
Copy link
Member

If this fully resolves #285, please put Resolves #285 in the description, to auto-close the ticket on merge.

@sniperking1234
Copy link
Contributor Author

@yurishkuro ok, I think the issue is fully resolved.

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #2704 (7b5ecd3) into master (29a8798) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   95.61%   95.58%   -0.04%     
==========================================
  Files         215      215              
  Lines        9580     9580              
==========================================
- Hits         9160     9157       -3     
- Misses        343      345       +2     
- Partials       77       78       +1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 83.03% <0.00%> (-1.79%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a8798...7b5ecd3. Read the comment docs.

@yurishkuro yurishkuro changed the title Clean-up "tcollector" Clean-up "tcollector" references Dec 25, 2020
@yurishkuro
Copy link
Member

thanks!

@yurishkuro yurishkuro merged commit 68acf65 into jaegertracing:master Dec 25, 2020
@sniperking1234 sniperking1234 deleted the fix_tcollector branch December 29, 2020 09:39
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean-up references to "tcollector"
3 participants