Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Support sampling strategies #5531

Closed
2 of 3 tasks
yurishkuro opened this issue Jun 4, 2024 · 0 comments · Fixed by #5802
Closed
2 of 3 tasks

[jaeger-v2] Support sampling strategies #5531

yurishkuro opened this issue Jun 4, 2024 · 0 comments · Fixed by #5802

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jun 4, 2024 •
edited

  • define sampling strategy extension
  • implement adaptive sampling processor
  • remove "sampling" flag from CI here and here
@yurishkuro yurishkuro mentioned this issue Jun 4, 2024
Merged
4 tasks
yurishkuro added a commit that referenced this issue Jul 14, 2024
@Pushkarm029 @yurishkuro
[jaeger-v2] Add remotesampling extension (#5389)
0616fba 
## Description of the changes
- Part of #5531
- adds static sampling support for otel-based jaeger-v2.
- supports hot reload
- added unit tests

## How was this change tested?
- `go run -tags=ui ./cmd/jaeger --config
./cmd/jaeger/config-badger.yaml`
- `make test`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <github@ysh.us>
FlamingSaint pushed a commit to FlamingSaint/jaeger that referenced this issue Jul 20, 2024
@Pushkarm029 @yurishkuro @FlamingSaint
[jaeger-v2] Add remotesampling extension (jaegertracing#5389)
cd5c1f7 
## Description of the changes
- Part of jaegertracing#5531
- adds static sampling support for otel-based jaeger-v2.
- supports hot reload
- added unit tests

## How was this change tested?
- `go run -tags=ui ./cmd/jaeger --config
./cmd/jaeger/config-badger.yaml`
- `make test`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro mentioned this issue Aug 5, 2024
Merged
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 7, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
7e584f1 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 8, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
ca2650a 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 13, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
38b8922 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 14, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
0e00194 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Jaeger V2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[v2] Enable remote sampling extension and include in e2e tests yurishkuro/jaeger
1 participant
@yurishkuro