Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing on Go-tip #5601

Closed
yurishkuro opened this issue Jun 12, 2024 · 1 comment
Closed

Improve testing on Go-tip #5601

yurishkuro opened this issue Jun 12, 2024 · 1 comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

We have a CI workflow that runs only on the main branch commits that in addition to regular unit tests runs them on gotip version of Go. Recently it started failing because it cannot download Go tip by commit hash, perhaps due to some upstream failure to build the distro.

The gotip installation is done by this action .github/actions/setup-go-tip/action.yml:

Proposal:

  • split this action into two steps:
    • first step to try to download the gotip distro and export a success/failure status (via echo "{name}={value}" >> "$GITHUB_OUTPUT")
    • second step to run only if previous step was successful and attempt to install the distro
  • add a third step to run only if step 1 failed and use a slower way to install (build) gotip: https://pkg.go.dev/golang.org/dl/gotip

In order to test the changes, I'd recommend implementing them first in a test project, similar to https://github.com/yurishkuro/test-project-3/tree/master/.github.

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jun 12, 2024
@varshith257
Copy link
Contributor

Taking this up!

yurishkuro added a commit that referenced this issue Jun 15, 2024
## Which problem is this PR solving?
#5601

## Description of the changes
Fixed gotip workflow according to proposal

## How was this change tested?
tested through
https://github.com/EraKin575/test-project/actions/runs/9495245139/job/26167103130

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

2 participants