Add alternate way to install gotip

[EraKin575]

Which problem is this PR solving?

#5601

Description of the changes

Fixed gotip workflow according to proposal

How was this change tested?

tested through https://github.com/EraKin575/test-project/actions/runs/9495245139/job/26167103130

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

This is not necessary, we will see if the previous steps fail.

[yurishkuro]

Please demonstrate how it was tested

[EraKin575]

Please demonstrate how it was tested

I tested it by making a workflow of my own and then running the actions file: https://github.com/EraKin575/test-project

[yurishkuro]

I tested it by making a workflow of my own and then running the actions file

in your test repo, can you add a step go version, to verify that the go command is now taken from gotip? The manual part in our action also sets PATH, but your additional step does not do that.

[yurishkuro]

I see this in your run https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:66

Success. You may now run 'gotip'!
Run echo "Active Go version:"
Active Go version:
go version go1.22.4 linux/amd[64](https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:67)

This isn't gotip. And I was expecting that, because you're not setting up env vars the same way as we do in L38-41. For example, you do GOROOT=$(go env GOROOT) - that's just default Go version, nothing to do with gotip.

[EraKin575]

Someting like this?

[yurishkuro]

Note - we could still make it work, I suppose, but then we need to change how the tests are run, e.g. make test GO=gotip

[yurishkuro]

Something like this?

I don't like "designing by screenshots" - you should test it out. This is why we have the final step to print go version

[yurishkuro]

I fixed it. After the manual build step, the gotip toolchain look good: https://github.com/jaegertracing/jaeger/actions/runs/9530915022/job/26271312690#step:5:125

Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /home/runner/sdk/gotip
Installed commands in /home/runner/sdk/gotip/bin
Success. You may now run 'gotip'!
Run echo Setup Go environment
Setup Go environment
go version devel go1.23-fe36ce6 Fri Jun 14 22:40:29 2024 +0000 linux/amd64
Run echo Check Go Version
Check Go Version
GOPATH=/home/runner/gotip
GOROOT=/home/runner/sdk/gotip
which go:
/home/runner/sdk/gotip/bin/go
/usr/bin/go
/bin/go
Active Go version:
go version devel go1.23-fe36ce6 Fri Jun 14 22:40:29 2024 +0000 linux/amd64