Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix failing kafka integration test" #1077

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

pavolloffay
Copy link
Member

Reverts #1068

See #1011 (comment)

… component, and generated for all span readers (not just ES) (#1074)"

This reverts commit e8e5962.
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1077   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         140     140           
  Lines        6622    6699   +77     
======================================
+ Hits         6622    6699   +77
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e5962...1f0db23. Read the comment docs.

@pavolloffay pavolloffay merged commit c3278b2 into master Sep 21, 2018
@ghost ghost removed the review label Sep 21, 2018
@pavolloffay pavolloffay deleted the revert-1068-fix-kafka-it-simple branch November 5, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants