Specify metric name/tags via annotation #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
objectiser
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
======================================
Coverage 100% 100%
======================================
Files 140 140
Lines 6625 6621 -4
======================================
- Hits 6625 6621 -4
Continue to review full report at Codecov.
|
Signed-off-by: Gary Brown <gary@brownuk.com>
yurishkuro
reviewed
Sep 29, 2018
| Responses metrics.Timer //used as a histogram, not necessary for GetTrace | ||
| ErrLatency metrics.Timer | ||
| OKLatency metrics.Timer | ||
| Errors metrics.Counter `metric:"calls" tags:"result=err"` |
There was a problem hiding this comment.
i think we usually call this "requests"
yurishkuro
reviewed
Sep 29, 2018
| "find_traces.calls|result=ok": 1, | ||
| "find_traces.calls|result=err": 0, | ||
| "get_services.calls|result=ok": 1, | ||
| "get_services.calls|result=err": 0, |
There was a problem hiding this comment.
what does the full name look like? Perhaps the operation name should be pushed into a tag as well: requests|operation=find_traces|result=ok
There was a problem hiding this comment.
Sounds good - the updated version is now:
jaeger_query_latency_bucket{operation="find_traces",result="err",le="0.005"} 0
jaeger_query_latency_bucket{operation="find_traces",result="ok",le="0.005"} 2
jaeger_query_requests{operation="find_traces",result="err"} 0
jaeger_query_requests{operation="find_traces",result="ok"} 2
jaeger_query_responses_bucket{operation="find_traces",le="0.005"} 2
Signed-off-by: Gary Brown <gary@brownuk.com>
yurishkuro
approved these changes
Sep 30, 2018
Signed-off-by: Gary Brown <gary@brownuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown gary@brownuk.com
Which problem is this PR solving?
Addresses #1075 (comment)
Only issue is that the metric field needs a name, empty string does not work, so have called the overall counter(success/error) 'calls'. If another word is preferred let me know.
Short description of the changes
Revert to using the annotation approach for defining metrics.