Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tag/Tags types, use KeyValue instead #11

Merged
merged 3 commits into from
Dec 19, 2016
Merged

Remove Tag/Tags types, use KeyValue instead #11

merged 3 commits into from
Dec 19, 2016

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 18, 2016 •
edited

Turns out the Tag type alias was causing more problems than it was solving.

Add KeyValue.AsString()

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2199395 on tag-as-string into f9b1642 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7612b67 on tag-as-string into f9b1642 on master.

@yurishkuro yurishkuro changed the title Add KeyValue.AsString() Remove Tag/Tags types, use KeyValue instead Dec 18, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b64b55d on tag-as-string into f9b1642 on master.

@yurishkuro yurishkuro merged commit d1b8e74 into master Dec 19, 2016
@yurishkuro yurishkuro deleted the tag-as-string branch December 21, 2016 19:50
ideepika pushed a commit to ideepika/jaeger that referenced this pull request Oct 22, 2017
@yurishkuro @ideepika
Remove Tag/Tags types, use KeyValue instead (jaegertracing#11)
4360ef2
bigfleet pushed a commit to bigfleet/jaeger that referenced this pull request Feb 16, 2023
@SudKul
Merge pull request jaegertracing#11 from parveshmourya/master
710e52a 
fix: update the vm box version from config.vm.box_version = "15.2.31.199" to config.vm.box_version = "15.2.31.354"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yurishkuro @coveralls @black-adder @badiib