Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jaeger community support URL #2868

Merged
merged 2 commits into from Mar 9, 2021

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

From Gitter -> Slack.

URL obtained by right-clicking #jaeger channel -> "Copy link".

@albertteoh albertteoh requested a review from a team as a code owner March 9, 2021 04:52
@mergify mergify bot requested a review from jpkrohling March 9, 2021 04:52
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2868 (099a2e0) into master (bcda38b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
+ Coverage   95.94%   95.95%   +0.01%     
==========================================
  Files         223      223              
  Lines        9675     9675              
==========================================
+ Hits         9283     9284       +1     
- Misses        323      324       +1     
+ Partials       69       67       -2     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.20% <0.00%> (-2.60%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.08% <0.00%> (+0.71%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcda38b...42e353f. Read the comment docs.

@yurishkuro
Copy link
Member

There's more than one reference:

./README.md:4:[![Gitter chat][gitter-img]][gitter]
./README.md:166: * [Gitter chat room](https://gitter.im/jaegertracing/Lobby)
./README.md:197:[gitter]: https://gitter.im/jaegertracing/Lobby
./README.md:198:[gitter-img]: https://img.shields.io/badge/gitter-join%20chat%20%E2%86%92-brightgreen.svg
./RELEASE.md:25:6. Announce the release on the [mailing list](https://groups.google.com/g/jaeger-tracing), [gitter](https://gitter.im/jaegertracing/Lobby), and [twitter](https://twitter.com/JaegerTracing?lang=en).
./.github/ISSUE_TEMPLATE/feature_request.md:17:    - our chat room https://gitter.im/jaegertracing/Lobby, or
./.github/ISSUE_TEMPLATE/config.yml:4:    url: https://gitter.im/jaegertracing/Lobby
./SECURITY.md:18:* Contact us on our open chat room on [Gitter][gitter-room]
./SECURITY.md:19:* If you can't use Gitter, send a message to [jaeger-tracing@googlegroups.com][mailing-list]
./SECURITY.md:20:* If you can't use Gitter nor send an email, open a merge request on GitHub: fork the affected repository and send us a pull request. We really prefer if you'd talk to us before, though, as our repositories are public and we would like to give a heads up to our users before disclosing it publicly
./SECURITY.md:94:[gitter-room]: https://gitter.im/jaegertracing/Lobby

See also jaegertracing/documentation#478

@albertteoh
Copy link
Contributor Author

Thanks for pointing that out @yurishkuro, I'll update those other refs too.

albertteoh added 2 commits March 9, 2021 17:37
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
@jpkrohling
Copy link
Contributor

Related to this: jaegertracing/documentation#478

@jpkrohling
Copy link
Contributor

jpkrohling commented Mar 9, 2021

Apparently, there's still one reference left:

./idl/.github/ISSUE_TEMPLATE.md:    - our chat room https://gitter.im/jaegertracing/Lobby, or

@albertteoh
Copy link
Contributor Author

Apparently, there's still one reference left:

./idl/.github/ISSUE_TEMPLATE.md:    - our chat room https://gitter.im/jaegertracing/Lobby, or

@jpkrohling I think idl is a submodule pointing to another repo: https://github.com/jaegertracing/jaeger-idl and so I'll need to create a separate PR there, along with jaeger-ui. I'll create an issue ticket to track what needs to change.

@jpkrohling
Copy link
Contributor

Yes, sorry, not enough coffee today. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants