Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]:Improve Kafka integration test self-sufficiency #4989

Merged

Conversation

RipulHandoo
Copy link
Contributor

Which problem is this PR solving?

Resolves #4982

Description of the changes

  • Introduced a -k parameter to the kafka-integration-test.sh script.
  • Modified the script to wait for Kafka availability before proceeding.

Checklist

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo requested a review from a team as a code owner December 4, 2023 17:38
@RipulHandoo RipulHandoo changed the title [ci]: Improve Kafka integration test self-sufficiency [ci]:Improve Kafka integration test self-sufficiency Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe444ef) 95.63% compared to head (559aa19) 95.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
- Coverage   95.63%   95.62%   -0.01%     
==========================================
  Files         319      319              
  Lines       18786    18786              
==========================================
- Hits        17966    17965       -1     
  Misses        659      659              
- Partials      161      162       +1     
Flag Coverage Δ
cassandra-3.x 25.63% <ø> (ø)
cassandra-4.x 25.63% <ø> (ø)
elasticsearch-5.x 19.90% <ø> (ø)
elasticsearch-6.x 19.90% <ø> (ø)
elasticsearch-7.x 20.04% <ø> (ø)
elasticsearch-8.x 20.13% <ø> (ø)
grpc-badger 19.52% <ø> (-0.05%) ⬇️
kafka 14.12% <ø> (ø)
opensearch-1.x 20.04% <ø> (ø)
opensearch-2.x 20.04% <ø> (ø)
unittests 93.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 4, 2023
@yurishkuro yurishkuro merged commit 939b56d into jaegertracing:main Dec 4, 2023
37 of 38 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Make Kafka integration test more self-siufficient
2 participants