Add manual implementation of APIv3 HTTP endpoints #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5054 +/- ##
==========================================
+ Coverage 95.55% 95.58% +0.03%
==========================================
Files 313 314 +1
Lines 18160 18321 +161
==========================================
+ Hits 17352 17513 +161
Misses 647 647
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
commented
Dec 28, 2023
| @@ -60,6 +61,9 @@ const ( | |||
| // REGENERATE_SNAPSHOTS=true go test -v ./cmd/query/app/apiv3/... | |||
| var regenerateSnapshots = os.Getenv("REGENERATE_SNAPSHOTS") == "true" | |||
|
|
|||
| // The tests in http_gateway_test.go set this to true to use manual gateway implementation. | |||
| var useHTTPGateway = false | |||
There was a problem hiding this comment.
not the cleanest way, but hopefully we'll just delete grpc-gateway based implementation soon and simplify/consolidate the tests
yurishkuro
commented
Dec 28, 2023
| // Unwrap the 'result' container generated by the gateway. | ||
| // See https://github.com/grpc-ecosystem/grpc-gateway/issues/2189 | ||
| type resultWrapper struct { | ||
| Result json.RawMessage `json:"result"` |
There was a problem hiding this comment.
to avoid this ugliness use the new helper types from IDL and marshal in one go.
yurishkuro
added
changelog:new-feature
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added a commit
that referenced
this pull request
Dec 30, 2023
## Which problem is this PR solving? - Part of #5052 - Continues #5054 - Closes #4911 ## Description of the changes - Replace grpc-gateway based implementation with manual HTTP implementation from #5054 - Clean up spurious grpc-gateway usage (e.g. all-in-one test that did not need it) - Delete grpc-gateway step from `make proto` and remove the corresponding generated file - `go mod tidy` removes grpc-gateway and github.com/golang/protobuf ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Follow-ups
How was this change tested?