Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grpc-gateway dependency #5060

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 29, 2023

Which problem is this PR solving?

Description of the changes

  • Replace grpc-gateway based implementation with manual HTTP implementation from Add manual implementation of APIv3 HTTP endpoints #5054
  • Clean up spurious grpc-gateway usage (e.g. all-in-one test that did not need it)
  • Delete grpc-gateway step from make proto and remove the corresponding generated file
  • go mod tidy removes grpc-gateway and github.com/golang/protobuf

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (718f666) 52.59% compared to head (f2b93b7) 95.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5060       +/-   ##
===========================================
+ Coverage   52.59%   95.60%   +43.00%     
===========================================
  Files         145      313      +168     
  Lines        8599    18292     +9693     
===========================================
+ Hits         4523    17488    +12965     
+ Misses       3728      644     -3084     
+ Partials      348      160      -188     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.88% <ø> (+0.01%) ⬆️
elasticsearch-7.x 20.02% <ø> (ø)
elasticsearch-8.x 20.11% <ø> (+0.01%) ⬆️
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.00% <ø> (-0.02%) ⬇️
opensearch-2.x 20.02% <ø> (ø)
unittests 93.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@@ -0,0 +1,193 @@
// Copyright (c) 2021 The Jaeger Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed from grpc_gateway_test.go

@yurishkuro yurishkuro marked this pull request as ready for review December 30, 2023 20:28
@yurishkuro yurishkuro requested a review from a team as a code owner December 30, 2023 20:28
@yurishkuro yurishkuro merged commit 003111b into jaegertracing:main Dec 30, 2023
38 checks passed
@yurishkuro yurishkuro deleted the remove-grpc-gateway branch December 30, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on deprecated github.com/golang/protobuf
1 participant