Introduce logging level configuration #514

pavolloffay · 2017-11-06T17:01:08Z

Logging struct was defined in flag package but not used. I have also removed unused code from there.

coveralls · 2017-11-06T17:10:07Z

Coverage remained the same at 100.0% when pulling 4a64414 on pavolloffay:logging-flag into 677251a on jaegertracing:master.

yurishkuro · 2017-11-06T17:44:34Z

cmd/collector/main.go

@@ -126,6 +134,7 @@ func main() {
 			case <-signalsChannel:
 				logger.Info("Jaeger Collector is finishing")
 			}
+			select {}


why is this needed?

yurishkuro · 2017-11-06T17:45:10Z

cmd/flags/flags.go

@@ -33,7 +33,7 @@ const (
 	// ESStorageType is the storage type flag denoting an ElasticSearch backing store
 	ESStorageType                  = "elasticsearch"
 	spanStorageType                = "span-storage.type"
-	logLevel                       = "log-level"
+	logLevel                       = "log-Level"


shouldn't it be lower case?

yurishkuro · 2017-11-06T17:46:19Z

cmd/query/main.go

@@ -118,6 +126,7 @@ func main() {
 			case <-serverChannel:
 				logger.Info("Jaeger Query is finishing")
 			}
+			select {}


yurishkuro · 2017-11-06T17:47:40Z

cmd/flags/flags.go

 	return flags
 }

 // AddFlags adds flags for SharedFlags
 func AddFlags(flagSet *flag.FlagSet) {
 	flagSet.String(spanStorageType, CassandraStorageType, fmt.Sprintf("The type of span storage backend to use, options are currently [%v,%v,%v]", CassandraStorageType, ESStorageType, MemoryStorageType))
-	flagSet.String(logLevel, "info", "Minimal allowed log level")
+	flagSet.String(logLevel, "info", "Minimal allowed log Level. For more levels see zap logger documentation")


instead of zap logger documentation I'd print the url

added but it looks a bit weird.

Message for conf file:

Configuration file in JSON, TOML, YAML, HCL, or Java properties formats (default none). See spf13/viper for precedence.

yurishkuro · 2017-11-06T17:49:36Z

cmd/flags/flags.go

+}
+
+// NewLogger pareses log Level
+func (flags *SharedFlags) NewLogger(conf zap.Config, options ...zap.Option) (*zap.Logger, error) {


it looks like in all cases you're passing zap.Production() as the config. Is there a use case you're thinking of when it's not going to be production? Also, do we need a way to affect that config from cmd line / our config?

Is there a use case you're thinking of when it's not going to be production? Also, do we need a way to affect that config from cmd line / our config?

Not right now. Maybe a debug flag or something like that in the future. I made this as flexible as possible.

So do you want to change it to the following?

func (flags *SharedFlags) NewLogger() (*zap.Logger, error)

yurishkuro · 2017-11-06T17:50:36Z

cmd/flags/flags.go

+	return nil
+}
+
+// NewLogger pareses log Level


typo "pareses"

yurishkuro · 2017-11-06T17:54:31Z

cmd/flags/flags.go

-
-func (co cassandraOptions) ServerList() []string {
-	return strings.Split(co.Servers, ",")
-}


yurishkuro · 2017-11-06T17:59:52Z

cmd/query/main.go

@@ -132,7 +141,8 @@ func main() {
 	)

 	if error := command.Execute(); error != nil {
-		logger.Fatal(error.Error())
+		fmt.Println(error.Error())


this is unfortunate, because a logger may print the error quite differently, e.g. with a stack trace, write to file, report to Sentry, etc. If we guaranteed that the command only returned errors when it can't init the logger, then it wouldn't be too bad, but I don't think this is generally the case.

This statement is invoked when:

an error is propagated from runE -> in all cases except logger creation and config file parsing zap.Fatal is called which directly calls os.exit.

cobra fails to parse flags e.g. a wrong/undefined flag

Other solution might be to use a default logger here.

coveralls · 2017-11-07T13:25:00Z

Coverage remained the same at 100.0% when pulling e7488af on pavolloffay:logging-flag into 677251a on jaegertracing:master.

coveralls · 2017-11-07T13:57:59Z

Coverage remained the same at 100.0% when pulling e960dc4 on pavolloffay:logging-flag into 2b73fe9 on jaegertracing:master.

yurishkuro · 2017-11-07T19:22:32Z

cmd/flags/flags.go

 	if file := v.GetString(configFile); file != "" {
 		v.SetConfigFile(file)
 		err := v.ReadInConfig()
 		if err != nil {
-			logger.Fatal("Error loading config file", zap.Error(err), zap.String(configFile, file))
+			errors.Wrap(err, fmt.Sprintf("Error loading config file %s", file))


missing return? And you can use Wrapf for extra formatting.

👍 ouch, the change from log Fatal :)

coveralls · 2017-11-08T09:48:02Z

Coverage remained the same at 100.0% when pulling 1c96e3f on pavolloffay:logging-flag into 2b73fe9 on jaegertracing:master.

coveralls · 2017-11-09T09:59:21Z

Coverage remained the same at 100.0% when pulling 3e0b69e on pavolloffay:logging-flag into a2ed9b8 on jaegertracing:master.

pavolloffay · 2017-11-10T14:06:29Z

@yurishkuro could you please re-review?

coveralls · 2017-11-13T09:52:31Z

Coverage increased (+0.05%) to 100.0% when pulling e2295a9 on pavolloffay:logging-flag into 32e2cd3 on jaegertracing:master.

yurishkuro · 2017-11-14T01:04:26Z

@pavolloffay could you please rebase from master to make sure all is clean? Then ok to merge.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

pavolloffay · 2017-11-14T08:52:12Z

@yurishkuro thanks, rebased, I will merge on green

coveralls · 2017-11-14T09:00:31Z

Coverage remained the same at 100.0% when pulling aa7915b on pavolloffay:logging-flag into e0a74f2 on jaegertracing:master.

pavolloffay requested review from black-adder, vprithvi and yurishkuro as code owners November 6, 2017 17:01

ghost assigned pavolloffay Nov 6, 2017

ghost added the review label Nov 6, 2017

yurishkuro reviewed Nov 6, 2017

View reviewed changes

cmd/flags/flags.go Outdated

return nil

}

// NewLogger pareses log Level

Copy link

Member

yurishkuro Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "pareses"

pavolloffay reacted with thumbs up emoji

yurishkuro reviewed Nov 6, 2017

View reviewed changes

cmd/flags/flags.go

func (co cassandraOptions) ServerList() []string {

return strings.Split(co.Servers, ",")

}

Copy link

Member

yurishkuro Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

yurishkuro reviewed Nov 6, 2017

View reviewed changes

pavolloffay force-pushed the logging-flag branch from e7488af to e960dc4 Compare November 7, 2017 13:48

yurishkuro reviewed Nov 7, 2017

View reviewed changes

pavolloffay force-pushed the logging-flag branch from 1c96e3f to c6560cb Compare November 9, 2017 09:46

pavolloffay force-pushed the logging-flag branch from 3e0b69e to e2295a9 Compare November 13, 2017 09:43

pavolloffay mentioned this pull request Nov 13, 2017

Change package from uber to jaegertracing #528

Merged

yurishkuro approved these changes Nov 14, 2017

View reviewed changes

pavolloffay added 3 commits November 14, 2017 09:50

Introduce logging level configuration

202e333

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

Fix review comments

f645dde

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

Add return

85c7f79

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

pavolloffay added 2 commits November 14, 2017 09:50

Remove debug printf

50304af

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

Revert empty select in agent

aa7915b

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

pavolloffay force-pushed the logging-flag branch from e2295a9 to aa7915b Compare November 14, 2017 08:51

pavolloffay merged commit 10d660f into jaegertracing:master Nov 14, 2017

ghost removed the review label Nov 14, 2017

cboggs mentioned this pull request May 4, 2018

jaeger-agent: --log-level flag not recognized #803

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce logging level configuration #514

Introduce logging level configuration #514

pavolloffay commented Nov 6, 2017

coveralls commented Nov 6, 2017

yurishkuro Nov 6, 2017

yurishkuro Nov 6, 2017

yurishkuro Nov 6, 2017

yurishkuro Nov 6, 2017

pavolloffay Nov 7, 2017

yurishkuro Nov 6, 2017

pavolloffay Nov 7, 2017

yurishkuro Nov 6, 2017

yurishkuro Nov 6, 2017

yurishkuro Nov 6, 2017

pavolloffay Nov 7, 2017

coveralls commented Nov 7, 2017

coveralls commented Nov 7, 2017

yurishkuro Nov 7, 2017

pavolloffay Nov 8, 2017

coveralls commented Nov 8, 2017

coveralls commented Nov 9, 2017 •

edited

Loading

pavolloffay commented Nov 10, 2017

coveralls commented Nov 13, 2017

yurishkuro commented Nov 14, 2017

pavolloffay commented Nov 14, 2017

coveralls commented Nov 14, 2017

Introduce logging level configuration #514

Introduce logging level configuration #514

Conversation

pavolloffay commented Nov 6, 2017

coveralls commented Nov 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 7, 2017

coveralls commented Nov 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 8, 2017

coveralls commented Nov 9, 2017 • edited Loading

pavolloffay commented Nov 10, 2017

coveralls commented Nov 13, 2017

yurishkuro commented Nov 14, 2017

pavolloffay commented Nov 14, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 9, 2017 •

edited

Loading