Add unit tests for anonymizer/app/writer #5162

h4shk4t · 2024-02-04T11:09:17Z

Which problem is this PR solving?

Part of #5068

Description of the changes

Added unit tests for cmd/anonymizer/app/writer/

How was this change tested?

go test -cover -v ./cmd/anonymizer/app/writer
make lint test

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/app/writer/writer_test.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/app/writer/writer_test.go

codecov · 2024-02-07T03:06:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd7c9d6) 94.09% compared to head (04ddd39) 94.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
+ Coverage   94.09%   94.38%   +0.29%     
==========================================
  Files         331      331              
  Lines       19156    19156              
==========================================
+ Hits        18025    18081      +56     
+ Misses        951      886      -65     
- Partials      180      189       +9

Flag	Coverage Δ
cassandra-3.x	`25.58% <ø> (ø)`
cassandra-4.x	`25.58% <ø> (ø)`
elasticsearch-5.x	`19.85% <ø> (-0.02%)`	⬇️
elasticsearch-6.x	`19.85% <ø> (-0.02%)`	⬇️
elasticsearch-7.x	`20.00% <ø> (ø)`
elasticsearch-8.x	`20.08% <ø> (ø)`
grpc-badger	`19.48% <ø> (-0.02%)`	⬇️
kafka	`14.09% <ø> (ø)`
opensearch-1.x	`20.00% <ø> (ø)`
opensearch-2.x	`19.98% <ø> (-0.02%)`	⬇️
unittests	`92.15% <100.00%> (+0.29%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/anonymizer/app/writer/writer_test.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/app/writer/writer.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/main.go

cmd/anonymizer/app/writer/writer_test.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/app/writer/writer_test.go

cmd/anonymizer/main.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

cmd/anonymizer/app/writer/writer_test.go

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro · 2024-02-09T17:57:09Z

Coverage 94.09% ==> 94.38%, nice! 🎉

…31709) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/jaegertracing/jaeger](https://togithub.com/jaegertracing/jaeger) | `v1.54.0` -> `v1.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jaegertracing/jaeger (github.com/jaegertracing/jaeger)</summary> ### [`v1.55.0`](https://togithub.com/jaegertracing/jaeger/releases/tag/v1.55.0): Release 1.55.0 [Compare Source](https://togithub.com/jaegertracing/jaeger/compare/v1.54.0...v1.55.0) ##### Backend Changes ##### ✨ New Features: - Support uploading traces to UI in OpenTelemetry format (OTLP/JSON) ([@NavinShrinivas](https://togithub.com/NavinShrinivas) in [#5155](https://togithub.com/jaegertracing/jaeger/pull/5155)) - Add Elasticsearch storage support for adaptive sampling ([@Pushkarm029](https://togithub.com/Pushkarm029) in [#5158](https://togithub.com/jaegertracing/jaeger/pull/5158)) ##### 🐞 Bug fixes, Minor Improvements: - Add the `print-config` subcommand ([@gmafrac](https://togithub.com/gmafrac) in [#5200](https://togithub.com/jaegertracing/jaeger/pull/5200)) - Return more detailed errors from ES storage ([@yurishkuro](https://togithub.com/yurishkuro) in [#5209](https://togithub.com/jaegertracing/jaeger/pull/5209)) - Bump go version ([@yurishkuro](https://togithub.com/yurishkuro) in [#5180](https://togithub.com/jaegertracing/jaeger/pull/5180)) ##### 🚧 Experimental Features: - \[jaeger-v2] Add support for gRPC storarge ([@james-ryans](https://togithub.com/james-ryans) in [#5228](https://togithub.com/jaegertracing/jaeger/pull/5228)) - \[jaeger-v2] Add support for Elasticsearch ([@akagami-harsh](https://togithub.com/akagami-harsh) in [#5152](https://togithub.com/jaegertracing/jaeger/pull/5152)) ##### 📊 UI Changes - UI pinned to version [1.39.0](https://togithub.com/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1390-2024-03-04). ##### 👏 New Contributors - [@h4shk4t](https://togithub.com/h4shk4t) made their first contribution in [jaegertracing/jaeger#5162 - [@NavinShrinivas](https://togithub.com/NavinShrinivas) made their first contribution in [jaegertracing/jaeger#5155 - [@prakrit55](https://togithub.com/prakrit55) made their first contribution in [jaegertracing/jaeger#5197 - [@gmafrac](https://togithub.com/gmafrac) made their first contribution in [jaegertracing/jaeger#5200 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

…pen-telemetry#31709) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/jaegertracing/jaeger](https://togithub.com/jaegertracing/jaeger) | `v1.54.0` -> `v1.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jaegertracing/jaeger (github.com/jaegertracing/jaeger)</summary> ### [`v1.55.0`](https://togithub.com/jaegertracing/jaeger/releases/tag/v1.55.0): Release 1.55.0 [Compare Source](https://togithub.com/jaegertracing/jaeger/compare/v1.54.0...v1.55.0) ##### Backend Changes ##### ✨ New Features: - Support uploading traces to UI in OpenTelemetry format (OTLP/JSON) ([@&open-telemetry#8203;NavinShrinivas](https://togithub.com/NavinShrinivas) in [#&open-telemetry#8203;5155](https://togithub.com/jaegertracing/jaeger/pull/5155)) - Add Elasticsearch storage support for adaptive sampling ([@&open-telemetry#8203;Pushkarm029](https://togithub.com/Pushkarm029) in [#&open-telemetry#8203;5158](https://togithub.com/jaegertracing/jaeger/pull/5158)) ##### 🐞 Bug fixes, Minor Improvements: - Add the `print-config` subcommand ([@&open-telemetry#8203;gmafrac](https://togithub.com/gmafrac) in [#&open-telemetry#8203;5200](https://togithub.com/jaegertracing/jaeger/pull/5200)) - Return more detailed errors from ES storage ([@&open-telemetry#8203;yurishkuro](https://togithub.com/yurishkuro) in [#&open-telemetry#8203;5209](https://togithub.com/jaegertracing/jaeger/pull/5209)) - Bump go version ([@&open-telemetry#8203;yurishkuro](https://togithub.com/yurishkuro) in [#&open-telemetry#8203;5180](https://togithub.com/jaegertracing/jaeger/pull/5180)) ##### 🚧 Experimental Features: - \[jaeger-v2] Add support for gRPC storarge ([@&open-telemetry#8203;james-ryans](https://togithub.com/james-ryans) in [#&open-telemetry#8203;5228](https://togithub.com/jaegertracing/jaeger/pull/5228)) - \[jaeger-v2] Add support for Elasticsearch ([@&open-telemetry#8203;akagami-harsh](https://togithub.com/akagami-harsh) in [#&open-telemetry#8203;5152](https://togithub.com/jaegertracing/jaeger/pull/5152)) ##### 📊 UI Changes - UI pinned to version [1.39.0](https://togithub.com/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1390-2024-03-04). ##### 👏 New Contributors - [@&open-telemetry#8203;h4shk4t](https://togithub.com/h4shk4t) made their first contribution in [jaegertracing/jaeger#5162 - [@&open-telemetry#8203;NavinShrinivas](https://togithub.com/NavinShrinivas) made their first contribution in [jaegertracing/jaeger#5155 - [@&open-telemetry#8203;prakrit55](https://togithub.com/prakrit55) made their first contribution in [jaegertracing/jaeger#5197 - [@&open-telemetry#8203;gmafrac](https://togithub.com/gmafrac) made their first contribution in [jaegertracing/jaeger#5200 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

Add unit tests for anonymizer/app/writer

29b3533

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

h4shk4t requested a review from a team as a code owner February 4, 2024 11:09

h4shk4t requested a review from pavolloffay February 4, 2024 11:09

Fix errors from make lint test

ab5ba41

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 5, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 5, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 5, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 5, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 5, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

Fix code quality

76af9d7

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

h4shk4t added 2 commits February 8, 2024 03:09

Add tags to tests and improve error handling in WriteSpan function

32bc420

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

Ensure writer is closed after running tests

b2bfc3e

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 7, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer.go Outdated Show resolved Hide resolved

Define constant error and perform os exit in main.go

b25f8ce

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 8, 2024

View reviewed changes

cmd/anonymizer/main.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 8, 2024

View reviewed changes

cmd/anonymizer/main.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 8, 2024

View reviewed changes

cmd/anonymizer/main.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 8, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Show resolved Hide resolved

Fix error handling

01f899e

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 9, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 9, 2024

View reviewed changes

cmd/anonymizer/main.go Outdated Show resolved Hide resolved

Fix errors and logging

121969e

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro reviewed Feb 9, 2024

View reviewed changes

cmd/anonymizer/app/writer/writer_test.go Outdated Show resolved Hide resolved

Fix defer statements

2c56c76

Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>

yurishkuro approved these changes Feb 9, 2024

View reviewed changes

yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Feb 9, 2024

Merge branch 'main' into anonymizer-writer-test

04ddd39

yurishkuro enabled auto-merge (squash) February 9, 2024 17:28

yurishkuro disabled auto-merge February 9, 2024 17:28

yurishkuro merged commit 951943f into jaegertracing:main Feb 9, 2024
36 of 37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests for anonymizer/app/writer #5162

Add unit tests for anonymizer/app/writer #5162

h4shk4t commented Feb 4, 2024 •

edited by yurishkuro

codecov bot commented Feb 7, 2024 •

edited

yurishkuro commented Feb 9, 2024

Add unit tests for anonymizer/app/writer #5162

Add unit tests for anonymizer/app/writer #5162

Conversation

h4shk4t commented Feb 4, 2024 • edited by yurishkuro

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov bot commented Feb 7, 2024 • edited

Codecov Report

yurishkuro commented Feb 9, 2024

h4shk4t commented Feb 4, 2024 •

edited by yurishkuro

codecov bot commented Feb 7, 2024 •

edited