Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Add remotesampling extension #5389

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Commits on Apr 25, 2024

  1. init

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1764c4c View commit details
    Browse the repository at this point in the history
  2. fix

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ac859c7 View commit details
    Browse the repository at this point in the history
  3. added README.md

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0b53417 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a7ba921 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. updated README.md

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5f267d0 View commit details
    Browse the repository at this point in the history
  2. fix

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    901f76a View commit details
    Browse the repository at this point in the history
  3. fix

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7a03553 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' into sampling_extension

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    36f38d2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. [e2e tests] Ping v2 binary to be ready before running tests (jaegertr…

    …acing#5382)
    
    This PR started as a dependabot upgrade of OTEL Collector dependencies,
    but the [tests were
    failing](https://github.com/jaegertracing/jaeger/actions/runs/8854720626/job/24318352528?pr=5382).
    
    The main change here is adding a ping from `e2eInitialize` to the
    jaeger-v2 binary to make sure that it started before proceeding with
    tests (ideally OTEL Collector should have a healthcheck endpoint that
    signals when all components have been started successfully).
    
    Also added some better logging.
    
    ---------
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Yuri Shkuro <github@ysh.us>
    2 people authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    cb0d857 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67f2203 View commit details
    Browse the repository at this point in the history
  3. Bump anchore/sbom-action from 0.15.10 to 0.15.11 (jaegertracing#5395)

    Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from
    0.15.10 to 0.15.11.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/anchore/sbom-action/releases">anchore/sbom-action's
    releases</a>.</em></p>
    <blockquote>
    <h2>v0.15.11</h2>
    <h2>Changes in v0.15.11</h2>
    <ul>
    <li>chore(deps): update Syft to v1.3.0 (<a
    href="https://redirect.github.com/anchore/sbom-action/issues/456">#456</a>)
    [<a
    href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li>
    <li>chore: remove outdated snapshot workflow (<a
    href="https://redirect.github.com/anchore/sbom-action/issues/457">#457</a>)
    [<a href="https://github.com/spiffcs">spiffcs</a>]</li>
    <li>fix: don't pass in a separate env. This makes it impossible to pass
    env vars via the action context to syft. (<a
    href="https://redirect.github.com/anchore/sbom-action/issues/455">#455</a>)
    [<a href="https://github.com/iNoahNothing">iNoahNothing</a>]</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/anchore/sbom-action/commit/7ccf588e3cf3cc2611714c2eeae48550fbc17552"><code>7ccf588</code></a>
    chore(deps): update Syft to v1.3.0 (<a
    href="https://redirect.github.com/anchore/sbom-action/issues/456">#456</a>)</li>
    <li><a
    href="https://github.com/anchore/sbom-action/commit/7f33cf5b409c25dd63ce12b34f585feaed60b5bf"><code>7f33cf5</code></a>
    chore: remove outdated snapshot workflow (<a
    href="https://redirect.github.com/anchore/sbom-action/issues/457">#457</a>)</li>
    <li><a
    href="https://github.com/anchore/sbom-action/commit/04a486a88617c017d26e11a4d30b3cd198f44824"><code>04a486a</code></a>
    fix: extend existing environment when invoking syft instead of creating
    a new...</li>
    <li>See full diff in <a
    href="https://github.com/anchore/sbom-action/compare/ab5d7b5f48981941c4c5d6bf33aeb98fe3bae38c...7ccf588e3cf3cc2611714c2eeae48550fbc17552">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=anchore/sbom-action&package-manager=github_actions&previous-version=0.15.10&new-version=0.15.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    9fcf052 View commit details
    Browse the repository at this point in the history
  4. [jaeger-v2] Normalize config names (jaegertracing#5400)

    ## Description of the changes
    - Use consistent naming for config files
    
    ## How was this change tested?
    - CI
    
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    yurishkuro authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    976dfb8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf8fe8d View commit details
    Browse the repository at this point in the history
  6. [jaeger-v2] Define an internal interface of storage v2 spanstore (jae…

    …gertracing#5399)
    
    ## Which problem is this PR solving?
    - Part of jaegertracing#5334
    
    ## Description of the changes
    - An API design of Storage V2 spanstore and its proto file.
    - For the detailed discussion and how we arrived to this design, please
    take a look at
    https://docs.google.com/document/d/1IvUcDsdRxMPK-xTUE32w3NSAGTkUcmnDQttN6ijUnWs/edit?usp=sharing
    
    ## How was this change tested?
    - This PR hasn't been tested yet since it only contains interfaces and
    no actual implementation to be tested.
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [ ] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    ---------
    
    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    james-ryans authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    a78782e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6ba2c8a View commit details
    Browse the repository at this point in the history
  8. Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (jaegertracing#…

    …5401)
    
    Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/protobuf&package-manager=go_modules&previous-version=1.33.0&new-version=1.34.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    
    
    </details>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    487013e View commit details
    Browse the repository at this point in the history
  9. Prepare releaes 1.57.0 (jaegertracing#5406)

    ## Description of the changes
    - This is the first jaeger release where Jaeger UI changes are included
    in the release notes and where we have version parity between the two
    repos.
    
    Signed-off-by: Albert Teoh <albert@packsmith.io>
    Co-authored-by: Albert Teoh <albert@packsmith.io>
    2 people authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    98b5f99 View commit details
    Browse the repository at this point in the history
  10. Add Purge method for ES/OS (jaegertracing#5407)

    ## Which problem is this PR solving?
    - part of jaegertracing#5345
    
    ## Description of the changes
    - Added Purge method for ES/OS
    - optimized integration test for es/os storage
    
    ## How was this change tested?
    - `STORAGE=elasticsearch make storage-integration-test`
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [x] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    ---------
    
    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7c7aa94 View commit details
    Browse the repository at this point in the history
  11. [es] Remove unused indexCache (jaegertracing#5408)

    ## Which problem is this PR solving?
    - The cache was initialized with incorrect parameter, and when I looked
    around it wasn't even used anywhere
    
    ## Description of the changes
    - delete indexCache and indexCacheTTL argument
    
    ## How was this change tested?
    ```
    $ go test ./plugin/storage/es/spanstore
    ok      github.com/jaegertracing/jaeger/plugin/storage/es/spanstore     0.471s
    ```
    
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    yurishkuro authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d631ae9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    96c4e33 View commit details
    Browse the repository at this point in the history
  13. Only build Docker images for Crossdock tests for linux/amd64 (jaegert…

    …racing#5410)
    
    ## Which problem is this PR solving?
    
    - Resolves jaegertracing#5350 
    
    
    ## Description of the changes
    - Added the logic same in the docker-image CI to build linux/amd64
    architecture only
    
    ## How was this change tested?
    - Not yet
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [x] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
    varshith257 authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    a3a3f20 View commit details
    Browse the repository at this point in the history
  14. Use helper action to retry codecov uploads (jaegertracing#5411)

    ## Which problem is this PR solving?
    - Objective is to cut down on the number of CI failures that are often
    due to codecov uploads failing
    - Resolves jaegertracing#5173
    - Supersedes and closes jaegertracing#5184
    
    ## Description of the changes
    - Add a new helper action which encapsulates defining a CODECOV token
    and uploading with retries
    
    ## How was this change tested?
    - CI
    
    ---------
    
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    yurishkuro authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    a15962b View commit details
    Browse the repository at this point in the history
  15. [jaeger-v2] add elasticsearch & opensearch e2e integration test (jaeg…

    …ertracing#5345)
    
    ## Which problem is this PR solving?
    - part of jaegertracing#5254 
    
    ## Description of the changes
    - Utilizing existing `StorageIntegration` to test the jaeger-v2 OTel
    Collector and gRPC storage backend with the provided config file at
    `cmd/jaeger/config-elasticsearch.yaml`.
    
    ## How was this change tested?
    - Start a elasticsearch or opensearch docker instance.
    - Run `STORAGE=elasticsearch SPAN_STORAGE_TYPE=elasticsearch make
    jaeger-v2-storage-integration-test`
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [x] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    ---------
    
    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    fab02d8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f1c253a View commit details
    Browse the repository at this point in the history
  17. Add Purge method for cassandra (jaegertracing#5414)

    ## Which problem is this PR solving?
    -
    jaegertracing#5398 (comment)
    
    ## Description of the changes
    - added purge for method for cassandra
    
    ## How was this change tested?
    - via integration tests
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [x] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    ---------
    
    Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    Co-authored-by: Yuri Shkuro <github@ysh.us>
    2 people authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    3579fe3 View commit details
    Browse the repository at this point in the history
  18. Add missing mermaid markup (jaegertracing#5413)

    ## Which problem is this PR solving?
    - Previous PR did not include markup and the diagram is not rendering
    correctly
    
    ## Description of the changes
    - Add markup
    
    Signed-off-by: Yuri Shkuro <github@ysh.us>
    yurishkuro authored and Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b4ab638 View commit details
    Browse the repository at this point in the history
  19. Merge branch 'main' into sampling_extension

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    74b07a0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. major changes

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fcc5547 View commit details
    Browse the repository at this point in the history
  2. some fixes

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8d4c4b1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. minor fix

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    076eb58 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. some progress

    Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2912e9a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    8fd879d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    bcd90b7 View commit details
    Browse the repository at this point in the history
  2. some changes

    Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    eb029f7 View commit details
    Browse the repository at this point in the history
  3. fix

    Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1631830 View commit details
    Browse the repository at this point in the history
  4. experimental config sharing

    Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    28f0dc9 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. fix

    Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f39093b View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. minor fix

    Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
    Pushkarm029 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    54a20fa View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Configuration menu
    Copy the full SHA
    9fb0797 View commit details
    Browse the repository at this point in the history