-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternate way to install gotip #5618
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cc84faa
fixed gotip installation workflow
EraKin575 ba2faf6
Merge branch 'jaegertracing:main' into gotip
EraKin575 29a8f98
Merge branch 'jaegertracing:main' into gotip
EraKin575 b372477
fixed gotip workflow
EraKin575 ce819a9
Merge branch 'gotip' of https://github.com/EraKin575/jaeger into gotip
EraKin575 498b492
fixed gotip workflow
EraKin575 ae17d69
Merge branch 'main' into gotip
EraKin575 c7a543e
added go version step
EraKin575 5f88e92
Merge branch 'gotip' of https://github.com/EraKin575/jaeger into gotip
EraKin575 8071d01
Merge branch 'main' into gotip
EraKin575 b621098
Merge branch 'main' into gotip
EraKin575 cf91ff3
fix
yurishkuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this in your run https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:66
This isn't gotip. And I was expecting that, because you're not setting up env vars the same way as we do in L38-41. For example, you do
GOROOT=$(go env GOROOT)
- that's just default Go version, nothing to do with gotip.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someting like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - we could still make it work, I suppose, but then we need to change how the tests are run, e.g.
make test GO=gotip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like "designing by screenshots" - you should test it out. This is why we have the final step to print go version