-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPM integration tests #5640
Conversation
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
==========================================
+ Coverage 96.36% 96.38% +0.01%
==========================================
Files 329 329
Lines 16060 16060
==========================================
+ Hits 15477 15479 +2
+ Misses 405 404 -1
+ Partials 178 177 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@hellspawn679 please make the suggested changes by @yurishkuro. If you need any help in getting this PR merged please let me know. |
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
## Which problem is this PR solving? - Part of #5608 - SPM Makefile was calling a target that was removed in previous refactoring ## Description of the changes - Build the image directly instead of calling much more expensive target - Use workflow added in #5640 to run the build - Change crossdock target to not build debug image with devle, which is expensive ## How was this change tested? - `make build && make dev` --------- Signed-off-by: mehul gautam <mehulsharma4786@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: mehul gautam <mehulsharma4786@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Raghuram Kannan <78465537+FlamingSaint@users.noreply.github.com> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
@yurishkuro Also, please take a look at the comments and let me know if there is a change required in them |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test