Add SPM integration tests #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
==========================================
+ Coverage 96.36% 96.38% +0.01%
==========================================
Files 329 329
Lines 16060 16060
==========================================
+ Hits 15477 15479 +2
+ Misses 405 404 -1
+ Partials 178 177 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
yurishkuro
reviewed
Jun 16, 2024
yurishkuro
reviewed
Jun 16, 2024
|
@hellspawn679 please make the suggested changes by @yurishkuro. If you need any help in getting this PR merged please let me know. |
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
yurishkuro
reviewed
Jun 18, 2024
yurishkuro
reviewed
Jun 18, 2024
yurishkuro
reviewed
Jun 18, 2024
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Merged
yurishkuro
added a commit
that referenced
this pull request
Jun 19, 2024
## Which problem is this PR solving? - Part of #5608 - SPM Makefile was calling a target that was removed in previous refactoring ## Description of the changes - Build the image directly instead of calling much more expensive target - Use workflow added in #5640 to run the build - Change crossdock target to not build debug image with devle, which is expensive ## How was this change tested? - `make build && make dev` --------- Signed-off-by: mehul gautam <mehulsharma4786@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: mehul gautam <mehulsharma4786@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Raghuram Kannan <78465537+FlamingSaint@users.noreply.github.com> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
reviewed
Jun 19, 2024
yurishkuro
reviewed
Jun 19, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
yurishkuro
reviewed
Jun 21, 2024
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
yurishkuro
reviewed
Jun 22, 2024
|
@yurishkuro Also, please take a look at the comments and let me know if there is a change required in them |
yurishkuro
reviewed
Jun 24, 2024
FlamingSaint
approved these changes
Jun 24, 2024
yurishkuro
approved these changes
Jun 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test