Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Gorilla router to allow slash in path params #736

Merged
merged 4 commits into from
Apr 3, 2018

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Mar 12, 2018

Fixes #586

@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ab843b3 on demo-586-not-working into 51c3bc8 on master.

Yuri Shkuro added 3 commits April 3, 2018 16:30
…arams

Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro changed the title [WIP] Test to demonstrate that Gorilla router does not like slash in path params Configure Gorilla router to allow slash in path params Apr 3, 2018
Signed-off-by: Yuri Shkuro <ys@uber.com>
Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro merged commit 4865de4 into master Apr 3, 2018
@ghost ghost removed the review label Apr 3, 2018
@yurishkuro yurishkuro deleted the demo-586-not-working branch April 3, 2018 21:56
mabn pushed a commit to mabn/jaeger that referenced this pull request Apr 3, 2018
* master:
  Configure Gorilla router to allow slash in path params (jaegertracing#736)
  Add go-bindata-assetfs to glide (jaegertracing#752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants