Add go-bindata-assetfs to glide

[cory-klein]

Resolves Issue #751

[coveralls]

Coverage remained the same at 100.0% when pulling 652a006 on cory-klein:master into 2e6323c on jaegertracing:master.

[pavolloffay]

CI failure is not related to this change. Fix is #753

@cory-klein could you please sign commits with -s when doing git commit?

[cory-klein]

@pavolloffay Done

[yurishkuro]

did you run glide up? We keep glide.lock under source control too, without it glide install will not install bindata, and you're back to the same problem.

[pavolloffay]

@cory-klein the change looks good, please just run glide up to add it to lock file

[cory-klein]

@pavolloffay Done

[pavolloffay]

it if failing on travis. Could you please also sing the last commit?

[cory-klein]

Doh, sorry forgot the -s on that last one. Re-committed with it included this time.

[cory-klein]

Build is failing here:

$ if [ "$CROSSDOCK" == true ]; then bash ./scripts/travis/build-crossdock.sh ; else echo 'skipping crossdock'; fi
CGO_ENABLED=0 GOOS=linux installsuffix=cgo go build -o ./cmd/agent/agent-linux -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=0decadb5a363030e422660e836fac82c4eaaab6c -X github.com/jaegertracing/jaeger/pkg/version.latestVersion=v1.2.0 -X github.com/jaegertracing/jaeger/pkg/version.date=2018-03-27T19:04:01Z" ./cmd/agent/main.go
# github.com/jaegertracing/jaeger/vendor/github.com/spf13/viper
vendor/github.com/spf13/viper/viper.go:1371:10: cannot assign 1 values to 2 variables
make: *** [build-agent-linux] Error 2
The command "if [ "$CROSSDOCK" == true ]; then bash ./scripts/travis/build-crossdock.sh ; else echo 'skipping crossdock'; fi" exited with 2.

But it's not apparent to me whether this could be caused by changes specific to this PR.

The cited viper.go code is here. Here is an excerpt:

		t, err := toml.TreeFromMap(c)
		if err != nil {
			return ConfigMarshalError{err}
}

[black-adder]

Looks like a breaking change was introduced in viper? Do you mind pinning viper to 25b30aa063fc18e48662b86996252eabdcf2f0c7 in glide.yaml and see if that passes?

[cory-klein]

@pavolloffay Mind checking one last time? All automated build checks finally passed.

[yurishkuro]

I don't think this is necessary, it looks like viper did a bad release 1.0.1 and then rolled back the change and re-released as 1.0.2, so our pin ^1 should still work.

[yurishkuro]

thanks!

[cory-klein]

@yurishkuro Everything looks green! 😄

[yurishkuro]

great, thanks!