Decouple DB and JSON conversions from protobuf strings #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #856 and #881
Unit tests for Cassandra DB model conversion were defining test fixtures using constants from
model
. As a result of #856 some of the constants were changed, in particular the string representation of the ValueType field in KeyValue struct was changed to upper-case letters. As a result, the conversion to DB model was producing backwards incompatible string constants, without any unit tests failing.This change removes
model.ValueTypeFromString
andmodel.SpanRefTypeFromString
functions to avoid accidental reliance on protobuf-produced string constants in other parts of the code. The conversion in json and cassandra/dbmodel packages is changed to use explicit mapping between domain constants and respective constants in the other models. Unit tests are changed to use the exact expected strings to avoid potential future regressions.