Include HotROD binary in the distributions #917
Conversation
yurishkuro
requested review from
black-adder,
jpkrohling,
pavolloffay and
vprithvi
as code owners
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 126 126
Lines 6071 6071
=====================================
Hits 6071 6071Continue to review full report at Codecov.
|
Makefile
Outdated
| @@ -208,15 +207,15 @@ docker: build_ui docker-no-ui | |||
|
|
|||
| .PHONY: build-binaries-linux | |||
| build-binaries-linux: | |||
| GOOS=linux $(MAKE) build-agent build-collector build-query build-all-in-one | |||
| GOOS=linux $(MAKE) build-agent build-collector build-query build-all-in-one build-examples | |||
There was a problem hiding this comment.
can these commands be DRY'd? looks like the only different is the GOOS
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
|
|
||
| .PHONE: docker-hotrod | ||
| docker-hotrod: build-examples | ||
| docker-hotrod: | ||
| GOOS=linux $(MAKE) build-examples |
There was a problem hiding this comment.
This sounds a bit odd. What was wrong with the previous approach?
There was a problem hiding this comment.
previously build-examples target didn't work for multiple architectures. Now it is in line with other build-{binary} targets.
There was a problem hiding this comment.
I see. And because it's Docker, GOOS=linux is appropriate. Makes sense, thanks for the explanation.
Along with #915 this allows running the whole HotROD demo without recompiling the service, and without Docker.
Also, replaces go-bindata with rakyl/statik, which is simpler to use.