Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HotROD binary in the distributions #917

Merged
merged 6 commits into from Jul 8, 2018

Conversation

Projects
None yet
3 participants
@yurishkuro
Copy link
Member

commented Jul 8, 2018

Along with #915 this allows running the whole HotROD demo without recompiling the service, and without Docker.

Also, replaces go-bindata with rakyl/statik, which is simpler to use.

@ghost ghost assigned yurishkuro Jul 8, 2018

@ghost ghost added the review label Jul 8, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 8, 2018

Codecov Report

Merging #917 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #917   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         126    126           
  Lines        6071   6071           
=====================================
  Hits         6071   6071

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cf3d1...a5a8e57. Read the comment docs.

Makefile Outdated
@@ -208,15 +207,15 @@ docker: build_ui docker-no-ui

.PHONY: build-binaries-linux
build-binaries-linux:
GOOS=linux $(MAKE) build-agent build-collector build-query build-all-in-one
GOOS=linux $(MAKE) build-agent build-collector build-query build-all-in-one build-examples

This comment has been minimized.

Copy link
@black-adder

black-adder Jul 8, 2018

Collaborator

can these commands be DRY'd? looks like the only different is the GOOS

yurishkuro added some commits Jul 8, 2018

Include HotROD binary in the distributions
Signed-off-by: Yuri Shkuro <ys@uber.com>
typo
Signed-off-by: Yuri Shkuro <ys@uber.com>
Switch to rakyl/statik for simpler web_assets handling
Signed-off-by: Yuri Shkuro <ys@uber.com>
Remove dead code
Signed-off-by: Yuri Shkuro <ys@uber.com>
exclude statik.go from license check
Signed-off-by: Yuri Shkuro <ys@uber.com>
DRY make commands
Signed-off-by: Yuri Shkuro <ys@uber.com>

@yurishkuro yurishkuro force-pushed the hotrod-binary branch from f97cf52 to a5a8e57 Jul 8, 2018

@yurishkuro yurishkuro merged commit 8a75233 into master Jul 8, 2018

6 of 7 checks passed

License Compliance 8 issues found
Details
DCO All commits have a DCO sign-off from the author
Details
WIP ready for review
Details
codecov/patch Coverage not affected when comparing e8cf3d1...a5a8e57
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ghost ghost removed the review label Jul 8, 2018

@yurishkuro yurishkuro deleted the hotrod-binary branch Jul 8, 2018


.PHONE: docker-hotrod
docker-hotrod: build-examples
docker-hotrod:
GOOS=linux $(MAKE) build-examples

This comment has been minimized.

Copy link
@jpkrohling

jpkrohling Jul 9, 2018

Member

This sounds a bit odd. What was wrong with the previous approach?

This comment has been minimized.

Copy link
@yurishkuro

yurishkuro Jul 9, 2018

Author Member

previously build-examples target didn't work for multiple architectures. Now it is in line with other build-{binary} targets.

This comment has been minimized.

Copy link
@jpkrohling

jpkrohling Jul 9, 2018

Member

I see. And because it's Docker, GOOS=linux is appropriate. Makes sense, thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.