Improve HotROD demo #915
Improve HotROD demo #915
Conversation
yurishkuro
requested review from
black-adder,
jpkrohling,
pavolloffay and
vprithvi
as code owners
ghost
assigned
yurishkuro
changed the title
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 126 126
Lines 6071 6071
=====================================
Hits 6071 6071Continue to review full report at Codecov.
|
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
examples/hotrod/cmd/root.go
Outdated
| @@ -51,23 +58,38 @@ func Execute() { | |||
|
|
|||
| func init() { | |||
| RootCmd.PersistentFlags().StringVarP(&metricsBackend, "metrics", "m", "expvar", "Metrics backend (expvar|prometheus)") | |||
| RootCmd.PersistentFlags().StringVarP(&jAgentHostPort, "jaeger-agent.host-port", "a", "0.0.0.0:6831", "String representing jaeger-agent host:port") | |||
| RootCmd.PersistentFlags().StringVarP(&jAgentHostPort, "jaeger-agent.host-port", "a", "0.0.0.0:6831", "String representing jaeger-agent UDP host:port") | |||
There was a problem hiding this comment.
should this also say that http host:port is accepted as well?
There was a problem hiding this comment.
we could say that, my main hesitation was that the property is called jaeger-agent.host-port, whereas an HTTP endpoint would be running in the collector, not the agent.
There was a problem hiding this comment.
doh, in that case, should we just add a new flag for jaeger-client.reporting-host-port? and say the old one is deprecated? it is a demo app, not sure if many would care.
There was a problem hiding this comment.
for now I added http to the description. I would rather not create another flag, as I think there's a better way - #920
Signed-off-by: Yuri Shkuro <ys@uber.com>
| RouteWorkerPoolSize = 3 | ||
| // MySQLMutexDisabled controls whether there is a mutex guarding db query execution. | ||
| // When not disabled it simulates a misconfigured connection pool of size 1. | ||
| MySQLMutexDisabled = false |
There was a problem hiding this comment.
Double negatives are confusing :-) How about MySQLMutexEnabled = true ?
There was a problem hiding this comment.
This isn't double negative, but more importantly disabled plays nicer with false as the default value.
hotrodnamespace to all metricsOn the topic of senders, the Go client, unfortunately, does not support JAEGER_ENDPOINT env variable like Java client does, and the current CLI argument is called
--jaeger-agent.host-port, even though it now accepts HTTP endpoint name.