Support reading multiple trace IDs from archive reader #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-adder
requested review from
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned
black-adder
commented
Jul 24, 2018
| } | ||
| if aH.handleError(w, err, http.StatusInternalServerError) { | ||
| return | ||
| } | ||
| process(trace) | ||
| } | ||
|
|
||
| func trace( |
There was a problem hiding this comment.
every combination of getTrace, getTraceFromReaders, etc. was taken. Uh getTraceFromReadersInternal?
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 136 136
Lines 6320 6322 +2
=====================================
+ Hits 6320 6322 +2
Continue to review full report at Codecov.
|
yurishkuro
changed the title
…Ds are passed as parameters Signed-off-by: Won Jun Jang <wjang@uber.com>
black-adder
force-pushed
the
archiveIsImportantToo
branch
from
1c7bff3
to
0686045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Ds are passed as parameters
Signed-off-by: Won Jun Jang wjang@uber.com
Which problem is this PR solving?