Add seek command (supersedes #344) #674

MichailiK · 2021-04-12T07:32:58Z

This pull request...

Fixes a bug
Introduces a new feature
Improves an existing feature
Boosts code quality or performance

Description

Allows DJs and user that added the track to perform a seek on a playing track

Purpose

Example: Going to a specific timestamp in a song compilation.

Relevant Issue(s)

This PR supersedes PR #344, as the author whew-inc stated that they will no longer be working on their pull request, I have decided to pick up on it

Currently, I am working on the change requests in #344.

starting a song at a specific time (both via the play command as well as in playlists; youtube has a format for this and jmusicbot should probably adapt that same format)

And, because YouTube's time parameter can either be just seconds or 1h2m3s

Allow parsing of such timespans. Maybe we could "inspire" a bit from Vortex?

Merge with upstream

# Conflicts: # src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java # src/main/java/com/jagrosh/jmusicbot/commands/music/QueueCmd.java

MichailiK · 2021-09-08T18:13:09Z

~~As of writing, the jcenter.bintray.com repository is unavailable, which houses lavaplayer-natives-extra and JLyrics. App Veyor's logs match with mine:~~

Maven output

[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.jagrosh:JMusicBot >------------------------
[INFO] Building JMusicBot Snapshot
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom (8.1 kB at 17 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9.2 kB at 135 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom (30 kB at 313 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom (15 kB at 221 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar (30 kB at 304 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.1/maven-compiler-plugin-3.1.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.1/maven-compiler-plugin-3.1.pom (10 kB at 134 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/24/maven-plugins-24.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/24/maven-plugins-24.pom (11 kB at 69 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/23/maven-parent-23.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/23/maven-parent-23.pom (33 kB at 582 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.1/maven-compiler-plugin-3.1.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.1/maven-compiler-plugin-3.1.jar (43 kB at 537 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom (10 kB at 109 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom (14 kB at 212 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar (30 kB at 350 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom (5.8 kB at 77 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 kB at 163 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom (26 kB at 342 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom (15 kB at 200 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar (34 kB at 382 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/1.5/maven-shade-plugin-1.5.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/1.5/maven-shade-plugin-1.5.pom (5.9 kB at 98 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/1.5/maven-shade-plugin-1.5.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/1.5/maven-shade-plugin-1.5.jar (83 kB at 648 kB/s)
Downloading from bintray-sedmelluq-com.sedmelluq: https://dl.bintray.com/sedmelluq/com.sedmelluq/com/sedmelluq/lavaplayer-natives-extra/1.3.13/lavaplayer-natives-extra-1.3.13.pom
Downloading from bintray-sedmelluq-com.sedmelluq: https://dl.bintray.com/sedmelluq/com.sedmelluq/com/jagrosh/JLyrics/0.5/JLyrics-0.5.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.259 s
[INFO] Finished at: 2021-09-08T20:04:18+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project JMusicBot: Could not resolve dependencies for project com.jagrosh:JMusicBot:jar:Snapshot: Failed to collect dependencies at com.sedmelluq:lavaplayer-natives-extra:jar:1.3.13: Failed to read artifact descriptor for com.sedmelluq:lavaplayer-natives-extra:jar:1.3.13: Could not transfer artifact com.sedmelluq:lavaplayer-natives-extra:pom:1.3.13 from/to bintray-sedmelluq-com.sedmelluq (https://dl.bintray.com/sedmelluq/com.sedmelluq): Authorization failed for https://dl.bintray.com/sedmelluq/com.sedmelluq/com/sedmelluq/lavaplayer-natives-extra/1.3.13/lavaplayer-natives-extra-1.3.13.pom 403 Forbidden -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

The dependency issues have been resolved now.

…feature/seeking � Conflicts: � src/main/java/com/jagrosh/jmusicbot/audio/AudioHandler.java � src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java � src/main/java/com/jagrosh/jmusicbot/commands/music/QueueCmd.java

Minenash · 2021-10-29T16:22:11Z

What still needs to be done before this can be merged?

antaxiom · 2021-12-16T22:12:28Z

I'd also like to know what else we need for this to be working

…feature/seeking � Conflicts: � src/main/java/com/jagrosh/jmusicbot/audio/AudioHandler.java � src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java

src/main/java/com/jagrosh/jmusicbot/utils/TimeUtil.java

n-tdi · 2023-07-01T03:00:11Z

Still waiting for this to be merged.

rojosinalma · 2023-07-12T01:01:28Z

@jagrosh will this be merged?

…feature/seeking # Conflicts: # src/main/java/com/jagrosh/jmusicbot/audio/AudioHandler.java # src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java # src/main/java/com/jagrosh/jmusicbot/commands/music/QueueCmd.java # src/main/java/com/jagrosh/jmusicbot/utils/FormatUtil.java

src/main/java/com/jagrosh/jmusicbot/utils/TimeUtil.java

src/main/java/com/jagrosh/jmusicbot/commands/music/SeekCmd.java

src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java

commit 8733899 Author: John Grosh <john.a.grosh@gmail.com> Date: Wed Jul 10 17:35:50 2024 -0400 Update bug-report.yml commit e5fd05e Author: Moritz Bender <35152647+Morilli@users.noreply.github.com> Date: Wed Jul 10 13:19:13 2024 +0200 Update dependencies to fix youtube issues (jagrosh#1609) commit 6a5a9c7 Author: John Grosh <john.a.grosh@gmail.com> Date: Fri May 10 17:43:49 2024 -0400 Change playlist page count (jagrosh#1542) * change playlist page count * make the value configurable * small refactor commit 8557f7a Author: Michaili K <git@michaili.dev> Date: Fri May 10 21:36:43 2024 +0200 Log track exceptions in the audio handler (jagrosh#1558) commit 48e62f1 Author: Michaili K <git@michaili.dev> Date: Fri May 10 21:32:30 2024 +0200 Revert "Always self-deafen (jagrosh#1491)" (jagrosh#1551) This reverts commit a7807b9. commit 6f12c33 Author: John Grosh <john.a.grosh@gmail.com> Date: Fri May 10 15:23:30 2024 -0400 custom eval engine (jagrosh#1530) commit 0afb3db Author: Michaili K <git@michaili.dev> Date: Fri May 10 20:19:11 2024 +0200 Switch to lavalink's new YouTube audio source manager (jagrosh#1552) * Switch to new lavalink's new YouTube audio source manager * Add back setPlaylistPageCount call for the youtube audio source manager * Manually add all the individual audio sources EXCEPT for old youtube * Remove unused import * Upgrade lavaplayer-youtube-source to 1.0.3 * Upgrade lavaplayer-youtube-source to 1.0.4 commit 81322ef Author: Michaili K <git@michaili.dev> Date: Fri May 10 20:14:28 2024 +0200 Add seek command (supersedes jagrosh#344) (jagrosh#674) * Add seek command * Combine nested if statements * Put the seek command in correct place to keep alphabetical order * Add license header * Brackets on next line * Restructure if-statements * Check for permissions with DJCommand#checkDJPermission * Make regex slightly smaller * Optimize imports * Output length of current track if requested seek time is invalid * Restate seeked point when seeked successfully * Add empty newline at end of file to keep consistency * Create TimeUtil class for parsing and formatting time * Move FormatUtil#formatTime to TimeUtil, and refactor * Apply requested changes (Pass 2) * Seek based on current position in track * Apply requested changes (Pass 3) * Add javadoc param * Apply requested changes (Pass 4) * Fix merge * Avoid reassigning parameter (Codacy) * Rework timestamp parsing * Refactor timestamp parsing * Apply requested changes (Pass 5) * Add examples in help * Apply requested changes (Pass 6) * Fix missing import * Keep track of start timestamp & add "unit" times * Fix my abdominal merge with QueuedTrack * Use RequestMetadata to store start timestamp * Store request info in request metadata * Add regex to try getting a timestamp from the url * Require RequestMetadata for QueuedTracks * Add some unit tests for unit seeking * Add docs & examples --------- Co-authored-by: Whew., Inc <22574706+Whew-Inc@users.noreply.github.com>

whew-inc and others added 30 commits January 22, 2020 04:27

Add seek command

cc336c7

Combine nested if statements

abd2c22

Put the seek command in correct place to keep alphabetical order

6fe00cd

Add license header

2bd70b8

Brackets on next line

f423b24

Restructure if-statements

7aecc0c

Check for permissions with DJCommand#checkDJPermission

270f5bc

Make regex slightly smaller

7fc52f2

Optimize imports

0c83119

Output length of current track if requested seek time is invalid

1e5df75

Restate seeked point when seeked successfully

06dc985

Add empty newline at end of file to keep consistency

3ce601f

Create TimeUtil class for parsing and formatting time

65792cc

Move FormatUtil#formatTime to TimeUtil, and refactor

65f2310

Apply requested changes (Pass 2)

10bc4f8

Seek based on current position in track

0ef1940

Apply requested changes (Pass 3)

20f2894

Add javadoc param

c6801ef

Apply requested changes (Pass 4)

f02416d

Merge branch 'master' into master

e922f8d

Fix merge

9b127ff

Avoid reassigning parameter (Codacy)

0c36f7d

Rework timestamp parsing

3a3e77d

Refactor timestamp parsing

9bccab5

Apply requested changes (Pass 5)

7c8a1f4

Add examples in help

b5673c5

Merge branch 'master' of https://github.com/jagrosh/MusicBot

0536e58

Merge with upstream

Apply requested changes (Pass 6)

605ae04

Merge branch 'master' of https://github.com/jagrosh/MusicBot

9bdaf36

Merge remote-tracking branch 'upstream/master' into pr/feature/seeking

583e80f

# Conflicts: # src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java # src/main/java/com/jagrosh/jmusicbot/commands/music/QueueCmd.java

MichailiK mentioned this pull request Sep 16, 2021

[Feature Request] Add the Ability to Skip to a Certain Time in a Song #469

Closed

MichailiK linked an issue Sep 16, 2021 that may be closed by this pull request

[Feature Request] Add the Ability to Skip to a Certain Time in a Song #469

Closed

MichailiK reopened this Sep 17, 2021

Keep track of start timestamp & add "unit" times

7bc85e2

CyberFlameGO mentioned this pull request Sep 25, 2021

Added seekto command #910

Closed

MichailiK added 3 commits October 4, 2021 17:45

Fix my abdominal merge with QueuedTrack

e1c5193

Use RequestMetadata to store start timestamp

a9d71ca

MichailiK mentioned this pull request Feb 19, 2022

[Feature Request] repeat specific length on a song #1120

Open

4 tasks

Merge branch 'master' of https://github.com/jagrosh/MusicBot into pr/…

351515a

…feature/seeking � Conflicts: � src/main/java/com/jagrosh/jmusicbot/audio/AudioHandler.java � src/main/java/com/jagrosh/jmusicbot/audio/QueuedTrack.java

MichailiK commented Apr 9, 2022

View reviewed changes

src/main/java/com/jagrosh/jmusicbot/utils/TimeUtil.java Show resolved Hide resolved

MichailiK added 3 commits April 19, 2022 00:19

Store request info in request metadata

6022e54

Add regex to try getting a timestamp from the url

72c8044

Require RequestMetadata for QueuedTracks

915735d

MichailiK marked this pull request as ready for review April 20, 2022 18:57

Add some unit tests for unit seeking

18e5d26

MichailiK requested a review from jagrosh April 20, 2022 19:21

MichailiK commented Mar 8, 2024

View reviewed changes

jagrosh added this to the 0.4.1 milestone Mar 14, 2024

Add docs & examples

84d2ef4

jagrosh merged commit 81322ef into jagrosh:master May 10, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add seek command (supersedes #344) #674

Add seek command (supersedes #344) #674

MichailiK commented Apr 12, 2021 •

edited

Loading

MichailiK commented Sep 8, 2021 •

edited

Loading

Minenash commented Oct 29, 2021

antaxiom commented Dec 16, 2021

n-tdi commented Jul 1, 2023

rojosinalma commented Jul 12, 2023

Add seek command (supersedes #344) #674

Add seek command (supersedes #344) #674

Conversation

MichailiK commented Apr 12, 2021 • edited Loading

This pull request...

Description

Purpose

Relevant Issue(s)

MichailiK commented Sep 8, 2021 • edited Loading

Minenash commented Oct 29, 2021

antaxiom commented Dec 16, 2021

n-tdi commented Jul 1, 2023

rojosinalma commented Jul 12, 2023

MichailiK commented Apr 12, 2021 •

edited

Loading

MichailiK commented Sep 8, 2021 •

edited

Loading