Skip to content

Commit

Permalink
Fix crashes on new v8
Browse files Browse the repository at this point in the history
Change-Id: Ia74f3eefcbd57473abcd450258657d8f6ea73ac7
  • Loading branch information
rmcc committed Dec 31, 2010
1 parent 64677f6 commit 8b2752e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions WebCore/bindings/v8/V8Proxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -818,10 +818,12 @@ bool V8Proxy::sourceLineNumber(int& result)
frameSourceLine = v8::Local<v8::Function>::Cast(v8UtilityContext->Global()->Get(v8::String::New("frameSourceLine")));
if (frameSourceLine.IsEmpty())
return false;
#if 0 // Causes crashes on new v8
v8::Handle<v8::Value> value = v8::Debug::Call(frameSourceLine);
if (value.IsEmpty())
return false;
result = value->Int32Value();
#endif
return true;
}

Expand All @@ -836,10 +838,12 @@ bool V8Proxy::sourceName(String& result)
frameSourceName = v8::Local<v8::Function>::Cast(v8UtilityContext->Global()->Get(v8::String::New("frameSourceName")));
if (frameSourceName.IsEmpty())
return false;
#if 0 // Causes crashes on new v8
v8::Handle<v8::Value> value = v8::Debug::Call(frameSourceName);
if (value.IsEmpty())
return false;
result = toWebCoreString(value);
#endif
return true;
}

Expand Down

0 comments on commit 8b2752e

Please sign in to comment.