[WIP] passing control of timeouts to Faraday #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of implementing our own timeout and retry mechanism, we rely on Faraday for that. We just pass `connection_timeout` and `read_timeout`, as well as `retries` to Faraday.
jaimeiniesta
force-pushed
the
faraday_timeouts
branch
from
a08ef65
to
5d44433
Compare
jaimeiniesta
added a commit
that referenced
this pull request
Nov 20, 2014
[WIP] passing control of timeouts to Faraday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #107 we should move the timeout control to Faraday itself.
This is still a work in progress, I still want to: