Explicitly require to define FaradayMiddleware::RedirectLimitReached

[luvtechno]

This change fixes an error of NameError: uninitialized constant FaradayMiddleware::RedirectLimitReached.

The issue is that MetaInspector::Request uses FaradayMiddleware::RedirectLimitReached as below, which can result in NameError: uninitialized constant when FaradayMiddleware::FollowRedirects is not loaded.

metainspector/lib/meta_inspector/request.rb

Line 44 in 8df66c0

rescue Faraday::Error::ConnectionFailed, Faraday::SSLError, URI::InvalidURIError, FaradayMiddleware::RedirectLimitReached => e

This happens because faraday_middleware auto-loads FaradayMiddleware::FollowRedirects class
as below, which also defines FaradayMiddleware::RedirectLimitReached error class in the same file.

https://github.com/lostisland/faraday_middleware/blob/895a55511699950c535d29291aa8e9dc70b7b6d4/lib/faraday_middleware.rb#L18

Explicit requiring of the file will fix the problem.

[jaimeiniesta]

Thanks! The PR looks fine but I would like to understand how we didn't catch this error before.

How can I reproduce it?

[luvtechno]

how we didn't catch this error before.

Yes, this is strange part. I also wonder why. Either 1) everyone is using allow_redirections option with metainspector, or 2) everyone who use metainspector always use FaradayMiddleware::FollowRedirects middleware, i guess 🤔

How can I reproduce it?

Here is the repro. This is the real example we came into this error.

$ irb
irb(main):001:0> require 'metainspector'
=> true
irb(main):002:0> url = "https://www.magata.net/memo/index.php?Blob%A5%C7%A1%BC%A5%BF%A4%F2%B0%B7%A4%A6%28Oracle%29"
=> "https://www.magata.net/memo/index.php?Blob%A5%C7%A1%BC%A5%BF%A4%F2%B0%B7%A4%A6%28Oracle%29"
irb(main):003:0> MetaInspector.new(url)
NameError: uninitialized constant FaradayMiddleware::RedirectLimitReached

[jaimeiniesta]

Thanks for the explanation!

I have reproduced the bug, and merged the fix. Now, however I run into a different error for that URL, ArgumentError: invalid byte sequence in US-ASCII.

Released in 5.4.3

[luvtechno]

Thank you!

Now, however I run into a different error for that URL, ArgumentError: invalid byte sequence in US-ASCII.

Character encoding issue always bites me... Anyways that's a separate issue and thanks for releasing it!