Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CDI API, introduce test for Instance.Handle. #308

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Update CDI API, introduce test for Instance.Handle. #308

merged 1 commit into from
Nov 1, 2021

Conversation

manovotn
Copy link
Contributor

Fixes #303

Introduces a test for Instance.Handle that asserts bean metadata, resolution and bean destruction (copied from Weld TS).
Also updates CDI API to latest version.
Lastly, I removed a TODO note in AbstractTest because we can now happily keep using BeanManager in these tests.

@manovotn manovotn requested a review from Ladicek October 29, 2021 09:30
@Ladicek
Copy link
Contributor

Ladicek commented Nov 1, 2021

OK, just one more question, otherwise LGTM.

@manovotn manovotn mentioned this pull request Nov 1, 2021
Merged
@manovotn
Copy link
Contributor Author

manovotn commented Nov 1, 2021

Pushed a tiny update that removed my leftover authorship on one of the files and changed variable naming in test from handler to handle.

@manovotn manovotn merged commit 0585828 into jakartaee:master Nov 1, 2021
@manovotn manovotn deleted the issue303 branch November 1, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide test coverage for programmatic lookup improvements
2 participants
@manovotn @Ladicek