Issue #424 passivation/activation and Annotated equality #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
reviewed
Feb 20, 2023
.../tests/full/context/passivating/dependency/builtin/BuiltinBeanPassivationDependencyTest.java
Show resolved
Hide resolved
|
Could you please rebase, or in some other way get rid of the 1st commit, which I think doesn't belong to this PR? |
|
Weird, but yes I'll see if I can get ride of the last commit |
jeanouii
force-pushed
the
Issue_424_passivation_activation
branch
from
9a1ec39
to
84ffcdd
Compare
|
Hopefully it's better. I extracted the method into the assert util class so it can be reused somewhere else if needed as your proposal was a bit more generic than what we needed |
|
LGTM, though you didn't necessarily have to remove the 2 asserts you added in the 1st commit, those are OK too. |
|
Added them back for completeness. |
Ladicek
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR addresses the challenge of #424