Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #473

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by Secure Repo at the request of @fperezel. Please merge the Pull Request to incorporate the requested changes. Please tag @fperezel on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.

Security Fixes

resolve: #472

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Pinned Dependencies

GitHub Action tags and Docker tags are mutatble. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

resolve: jakartaee#472

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same comment as jakartaee/cdi#678

@Ladicek
Copy link
Contributor

Ladicek commented Jun 7, 2023

LGTM, but a 2nd review would be nice.

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I do think that interval: daily is overly aggressive but we can change that later on if it proves annoying.

@ghost
Copy link

ghost commented Jun 24, 2023

Hi,

The interval could be configured to weekly or monthly, more information here, https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#scheduleinterval

Besides, if open-pull-requests-limit: 0 is configured, dependabot will only alert about security updates. Please find below an example testing out this PR in other repo, https://github.com/DummyOrganisationTest/jakartaee_cdi-tck_test/pulls

Finally, please don't hesitate and let me know if only security update will be needed.

Cheers,
FP

@starksm64 starksm64 merged commit 177b46d into jakartaee:master Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Best Practices
4 participants