Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the JBoss tagline from license headers #527

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 16, 2024

No description provided.

@Ladicek
Copy link
Contributor Author

Ladicek commented Jan 16, 2024

For the record, this is how I created this PR:

find . -name *.java -print0 | xargs -0 sed -i -e '/Home of Professional Open Source/d'

There were 3 files that got wiped completely and I had to fix those manually.

@Azquelt
Copy link
Contributor

Azquelt commented Jan 16, 2024

I've eyeballed the whole change (my eyeballs are now tired) and it looks good to me.

The three weird files are

/impl/src/main/java/org/jboss/cdi/tck/tests/implementation/producer/method/definition/BlackWidow.java
/impl/src/main/java/org/jboss/cdi/tck/tests/lookup/circular/DependentSelfConsumingNormalProducer.java
/impl/src/main/java/org/jboss/cdi/tck/tests/lookup/circular/NormalSelfConsumingNormalProducer.java

They're using \r rather than \n for their end of line character, we should probably fix that once this is merged.

@Ladicek
Copy link
Contributor Author

Ladicek commented Jan 17, 2024

Thanks for listing those files, I agree we should just convert them to LF line endings. Added a 2nd commit that does that.

Copy link
Contributor

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a quick scan of the changes and it looks good.
The second commit makes sense as well, thanks for noticing that.

@Ladicek Ladicek merged commit 046e78e into jakartaee:master Jan 17, 2024
4 checks passed
@Ladicek Ladicek deleted the remove-jboss-tagline branch January 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants