Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tests that use qualifiers with an *Definition annotation that is put on a class not scanned by CDI #489

Closed
Tracked by #472
arjantijms opened this issue May 8, 2024 · 2 comments · Fixed by #491
Closed
Tracked by #472

Adjust tests that use qualifiers with an *Definition annotation that is put on a class not scanned by CDI #489

arjantijms opened this issue May 8, 2024 · 2 comments · Fixed by #491
Assignees
@njr-11
Labels
EE11 Suggested changes for Jakarta EE 11 TCK
Milestone
3.1.0

Comments

@arjantijms
Copy link
Contributor

*Definition annotations with qualifiers are intended to be processed by CDI. Therefor it's crucial they are also visible to CDI, which means they have to appear on a bean that is set to be scanned by CDI.

At the moment "AnnotationFullTests" in the Concurrency TCK has a Servlet that in the archive its in, is not scanned by CDI and has the mentioned *Definition annotation with qualifiers. This class should be set to be scanned by CDI. Either by giving is a bean defining annotation (e.g. @ApplicationScoped) or using a beans.xml that dictates that CDI should scan all classes.
@arjantijms arjantijms added TCK EE11 Suggested changes for Jakarta EE 11 labels May 8, 2024
@arjantijms arjantijms added this to the 3.1 milestone May 8, 2024
@arjantijms
Copy link
Contributor Author

See also jakartaee/specifications#733 (comment)

@arjantijms
Copy link
Contributor Author

CC @aubi @OndroMih

njr-11 added a commit to njr-11/concurrency-api that referenced this issue May 8, 2024
@njr-11
Issue jakartaee#489 add ApplicationScoped to TCK servlet that defines…
fa2de82 
… resources with qualifiers

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@njr-11 njr-11 mentioned this issue May 8, 2024
Closed
OndroMih added a commit to OndroMih/jakartaee-concurrency that referenced this issue May 8, 2024
@OndroMih
The class with definitions that contain qualifiers is turned into a C…
d629e8a 
…DI bean

Fixes jakartaee#489
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih OndroMih mentioned this issue May 8, 2024
Merged
OndroMih added a commit to OndroMih/jakartaee-concurrency that referenced this issue May 9, 2024
@OndroMih
Use @dependent because other scopes may not be allowed on some servers.
5c26b97 
This is because Servlet 3.0 explicitly forbids using other CDI qualifiers on servlets. Although it seems that this restriction was removed, some servers still abide it.
Fixes jakartaee#489
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@KyleAure KyleAure mentioned this issue May 10, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njr-11 njr-11

Labels
EE11 Suggested changes for Jakarta EE 11 TCK
Projects
None yet
Milestone
3.1.0
2 participants
@arjantijms @njr-11