Replace TestNG with Junit5 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleAure
added
enhancement
KyleAure
force-pushed
the
277-switch-to-junit5
branch
from
0427d82
to
aeccde0
Compare
|
Ran verification testing on Open Liberty and have all tests running and passing: |
KyleAure
force-pushed
the
277-switch-to-junit5
branch
from
aeccde0
to
159fb8d
Compare
njr-11
approved these changes
Jun 19, 2023
...main/java/ee/jakarta/tck/concurrent/framework/arquillian/extensions/TCKArchiveProcessor.java
Outdated
Show resolved
Hide resolved
| // Ensure user is running on JDK 11 or higher, different JDKs produce different | ||
| // signatures | ||
| int javaSpecVersion = Integer.parseInt(System.getProperty("java.specification.version")); | ||
| assertTrue(javaSpecVersion >= 11, "The signature tests must be run on a JVM using Java 11 or higher."); |
There was a problem hiding this comment.
Yes, but the signature file currently in GitHub (unchanged in this PR) was generated using Java 11 so this is still accurate. I will update the signature file, and this test after this refactoring.
This work is currently being tracked under issue #282
mswatosh
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
Necessary refactor to ensure we meet the TCK guidelines here: https://github.com/jakartaee/platform-tck/wiki/Standard-Rules-while-separating-standalone-TCKs-from-platform-TCK