concurrency resources via @Inject and with qualifiers #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iers Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11
added
enhancement
KyleAure
approved these changes
Oct 3, 2023
|
|
||
| Copyright (c) 2013, 2023 Oracle and/or its affiliates. All rights reserved. | ||
| Copyright (c) 2013, 2024 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Should we wait to update the copyright until we have changes to the spec that happen in 2024?
There was a problem hiding this comment.
Yes, thank you for spotting that. It's a mistake, and I added e743973 to correct it.
OndroMih
reviewed
Oct 10, 2023
| @@ -39,9 +42,19 @@ | |||
| * unchanged = TRANSACTION, | |||
| * cleared = ALL_REMAINING) | |||
There was a problem hiding this comment.
I think you missed the qualifiers = MyQualifier.class
There was a problem hiding this comment.
I think you missed the
qualifiers = MyQualifier.class
Thanks! I have fixed it in commit b377e7a
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #229
This pull adds to the specification the ability to use
@Injectto obtain the default instances of ManagedExecutorService, ManagedScheduledExecutorService, ContextService, and ManagedThreadFactory.It also adds the ability to optionally include qualifiers on the resource definition annotations (ManagedExecutorDefinition, ManagedScheduledExecutorDefinition, ContextServiceDefinition, and ManagedThreadFactoryDefinition, in which case resources produced by them are injectable with the qualifiers.