Fix minor issues in TCK #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KyleAure
commented
Oct 26, 2023
KyleAure
commented
- Missing assertions from previous refactoring
- Trigger test hardened for failures due to hardware performance (this could be more liberal if needed)
- A test was written to use the wrong counter potentially leading to false positives
- assertTimeoutPreemptively is susceptible to leaking threads so avoid using in certain situations.
KyleAure
force-pushed
the
fix-tck-errors
branch
from
48dfbdd
to
f6fd978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.