Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds and update templates #387

Merged
merged 4 commits into from Nov 28, 2023
Merged

Fix builds and update templates #387

merged 4 commits into from Nov 28, 2023

Conversation

KyleAure
Copy link
Contributor

This pull request fixes the following issues:

  1. The release workflow did not create a pull request to update the issue templates
  • Fixed by ensuring we checkout the correct branch, and don't attempt to output multiple lines to a single $GITHUB_OUTPUT variable
  1. Manually updated the issue templates to include the M1 release
  2. Reduced duplicate code by introducing a script to checkout a branch and a reusable workflow for creating a pull request.

@KyleAure KyleAure added the build CI/CD pipelines related tasks. label Nov 27, 2023
@KyleAure KyleAure self-assigned this Nov 27, 2023
@mswatosh
Copy link
Member

Looks good, the generated files automation will be nice to have

@KyleAure
Copy link
Contributor Author

@mswatosh had to make one minor change to ensure the branches created for automated PRs are based off of main and not the release branch.

@mswatosh mswatosh self-requested a review November 28, 2023 14:17
mswatosh
mswatosh approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional change looks good 👍

@KyleAure KyleAure merged commit 035200f into jakartaee:main Nov 28, 2023
3 checks passed
@KyleAure KyleAure deleted the fix-ci branch November 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh approved these changes

Assignees

@KyleAure KyleAure

Labels
build CI/CD pipelines related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KyleAure @mswatosh